Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haproxy "sram is not available" uses wrong colour for orange bar #507

Closed
FlorisFokkinga opened this issue Mar 25, 2024 · 6 comments · Fixed by #512
Closed

haproxy "sram is not available" uses wrong colour for orange bar #507

FlorisFokkinga opened this issue Mar 25, 2024 · 6 comments · Fixed by #512
Milestone
v33

Comments

@FlorisFokkinga
Copy link
Contributor

It is based on the former style header and footer.

https://github.com/SURFscz/SRAM-deploy/blob/main/roles/lb_haproxy/templates/error_sram_down.html.j2

Image
@FlorisFokkinga FlorisFokkinga converted this from a draft issue Mar 25, 2024
@mrvanes
Copy link
Contributor

mrvanes commented Mar 25, 2024

Where is the new style header and footer?

@FlorisFokkinga
Copy link
Contributor Author

From the normal SBS UI.

@mrvanes mrvanes linked a pull request Mar 25, 2024 that will close this issue
Fix loadbalancer error_sram_down page #508
Merged
@mrvanes mrvanes moved this from Todo to To be tested in SRAM development Mar 25, 2024
@baszoetekouw baszoetekouw added this to the v33 milestone Apr 8, 2024
@baszoetekouw
Copy link
Member

Image

@baszoetekouw baszoetekouw moved this from To be tested to Done in SRAM development Apr 30, 2024
@baszoetekouw baszoetekouw moved this from Done to To be deployed in SRAM development Apr 30, 2024
@FlorisFokkinga FlorisFokkinga moved this from To be deployed to In progress in SRAM development May 1, 2024
@FlorisFokkinga
Copy link
Contributor Author

Sorry, but that's not the standard footer. :)

This is, but hide the language chooser if it doesn't work.

image

@mrvanes mrvanes removed a link to a pull request May 1, 2024
Fix loadbalancer error_sram_down page #508
Merged
@mrvanes
Copy link
Contributor

mrvanes commented May 1, 2024

#512

@mrvanes mrvanes moved this from In progress to To be tested in SRAM development May 1, 2024
@baszoetekouw baszoetekouw linked a pull request May 2, 2024 that will close this issue
Improve haproxy 503 footer #512
Merged
@baszoetekouw baszoetekouw changed the title haproxy "sram is not available" uses wrong colout for orange bar haproxy "sram is not available" uses wrong colour for orange bar May 2, 2024
@baszoetekouw
Copy link
Member

Screenshot 2024-05-02 at 18 18 02

@FlorisFokkinga

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development May 2, 2024
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SRAM development
Archived in project
Milestone
v33
Development

Successfully merging a pull request may close this issue.

Improve haproxy 503 footer SURFscz/SRAM-deploy
3 participants
@baszoetekouw @mrvanes @FlorisFokkinga