More cleanup

mnadareski · mnadareski · commit efef8d494e1c · 2026-01-27T09:30:58.000-05:00
diff --git a/BinaryObjectScanner/FileType/AACSMediaKeyBlock.cs b/BinaryObjectScanner/FileType/AACSMediaKeyBlock.cs
@@ -1,5 +1,6 @@
 using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/BDPlusSVM.cs b/BinaryObjectScanner/FileType/BDPlusSVM.cs
@@ -1,5 +1,6 @@
 using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/DetectableBaseT.cs b/BinaryObjectScanner/FileType/DetectableBaseT.cs
@@ -1,6 +1,7 @@
 using BinaryObjectScanner.Interfaces;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/DiskImage.cs b/BinaryObjectScanner/FileType/DiskImage.cs
@@ -4,6 +4,7 @@
 using SabreTools.IO.Extensions;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/Executable.cs b/BinaryObjectScanner/FileType/Executable.cs
@@ -6,6 +6,7 @@
 using SabreTools.IO.Extensions;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/ISO9660.cs b/BinaryObjectScanner/FileType/ISO9660.cs
@@ -7,6 +7,7 @@
 using SabreTools.Data.Models.ISO9660;
 using SabreTools.IO.Extensions;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/LDSCRYPT.cs b/BinaryObjectScanner/FileType/LDSCRYPT.cs
@@ -1,5 +1,6 @@
 ﻿using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/LinearExecutable.cs b/BinaryObjectScanner/FileType/LinearExecutable.cs
@@ -2,6 +2,7 @@
 using System.IO;
 using BinaryObjectScanner.Data;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/MSDOS.cs b/BinaryObjectScanner/FileType/MSDOS.cs
@@ -2,6 +2,7 @@
 using System.IO;
 using BinaryObjectScanner.Data;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/NewExecutable.cs b/BinaryObjectScanner/FileType/NewExecutable.cs
@@ -2,6 +2,7 @@
 using System.IO;
 using BinaryObjectScanner.Data;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/PLJ.cs b/BinaryObjectScanner/FileType/PLJ.cs
@@ -1,6 +1,7 @@
 ﻿using System.IO;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/PortableExecutable.cs b/BinaryObjectScanner/FileType/PortableExecutable.cs
@@ -2,6 +2,7 @@
 using System.IO;
 using BinaryObjectScanner.Data;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/RealArcadeInstaller.cs b/BinaryObjectScanner/FileType/RealArcadeInstaller.cs
@@ -1,5 +1,6 @@
 ﻿using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs b/BinaryObjectScanner/FileType/RealArcadeMezzanine.cs
@@ -1,5 +1,6 @@
 ﻿using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/SFFS.cs b/BinaryObjectScanner/FileType/SFFS.cs
@@ -1,5 +1,6 @@
 ﻿using System.IO;
 
+#pragma warning disable IDE0290 // Use primary constructor
 namespace BinaryObjectScanner.FileType
 {
     /// <summary>
diff --git a/BinaryObjectScanner/FileType/Textfile.cs b/BinaryObjectScanner/FileType/Textfile.cs
@@ -153,7 +153,6 @@ public class Textfile : DetectableBase
                         protections.Add("SafeDiscLT for Macintosh (Unknown Version - Please report to us on GitHub)");
                 }
 
-
                 // The full line from a sample is as follows:
                 //
                 // The files securom_v7_01.dat and securom_v7_01.bak have been created during the installation of a SecuROM protected application.
diff --git a/BinaryObjectScanner/Packer/UPX.cs b/BinaryObjectScanner/Packer/UPX.cs
@@ -4,6 +4,8 @@
 using BinaryObjectScanner.Interfaces;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Packer
 {
     // TODO: Add extraction
diff --git a/BinaryObjectScanner/Protection/AlphaROM.cs b/BinaryObjectScanner/Protection/AlphaROM.cs
@@ -6,6 +6,7 @@
 using SabreTools.IO.Extensions;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/CDDVDCops.cs b/BinaryObjectScanner/Protection/CDDVDCops.cs
@@ -8,6 +8,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/CactusDataShield.cs b/BinaryObjectScanner/Protection/CactusDataShield.cs
@@ -3,6 +3,7 @@
 using SabreTools.IO;
 using SabreTools.IO.Matching;
 
+#pragma warning disable IDE0230 // Use UTF-8 string literal
 namespace BinaryObjectScanner.Protection
 {
     public class CactusDataShield : IContentCheck
diff --git a/BinaryObjectScanner/Protection/Denuvo.cs b/BinaryObjectScanner/Protection/Denuvo.cs
@@ -7,6 +7,7 @@
 using SabreTools.Serialization.Wrappers;
 using OHMN = SabreTools.Data.Models.COFF.OptionalHeaderMagicNumber;
 
+#pragma warning disable IDE0230 // Use UTF-8 string literal
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/InterLok.cs b/BinaryObjectScanner/Protection/InterLok.cs
@@ -2,6 +2,7 @@
 using BinaryObjectScanner.Interfaces;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Protection
 {
     public class InterLok : IExecutableCheck<PortableExecutable>
diff --git a/BinaryObjectScanner/Protection/Macrovision.CDilla.cs b/BinaryObjectScanner/Protection/Macrovision.CDilla.cs
@@ -5,6 +5,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.CactusDataShield.cs b/BinaryObjectScanner/Protection/Macrovision.CactusDataShield.cs
@@ -7,6 +7,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.FLEXnet.cs b/BinaryObjectScanner/Protection/Macrovision.FLEXnet.cs
@@ -5,6 +5,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.RipGuard.cs b/BinaryObjectScanner/Protection/Macrovision.RipGuard.cs
@@ -6,6 +6,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.SafeCast.cs b/BinaryObjectScanner/Protection/Macrovision.SafeCast.cs
@@ -6,6 +6,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.SafeDisc.cs b/BinaryObjectScanner/Protection/Macrovision.SafeDisc.cs
@@ -7,6 +7,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.SafeWrap.cs b/BinaryObjectScanner/Protection/Macrovision.SafeWrap.cs
@@ -1,5 +1,7 @@
 ﻿using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable CA1822 // Mark members as static
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/Macrovision.cs b/BinaryObjectScanner/Protection/Macrovision.cs
@@ -8,6 +8,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable IDE0060 // Remove unused parameter
 namespace BinaryObjectScanner.Protection
 {
     /// <summary>
diff --git a/BinaryObjectScanner/Protection/PhenoProtect.cs b/BinaryObjectScanner/Protection/PhenoProtect.cs
@@ -1,6 +1,6 @@
 ﻿namespace BinaryObjectScanner.Protection
 {
-    public class phenoProtect
+    public class PhenoProtect
     {
         // Currently implemented as a text file check, more checks are likely possible but currently unknown.
         // Current checks based off Redump entry 84082 are found in the InstallShield setup.inx file, but the game also checks if the original disc is present in the drive after installation as well, so it seems unlikely for the InstallShield check to be relevant at that stage.
diff --git a/BinaryObjectScanner/Protection/ProtectDISC.cs b/BinaryObjectScanner/Protection/ProtectDISC.cs
@@ -9,6 +9,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Protection
 {
     // This protection was called VOB ProtectCD / ProtectDVD in versions prior to 6
diff --git a/BinaryObjectScanner/Protection/SecuROM.cs b/BinaryObjectScanner/Protection/SecuROM.cs
@@ -9,6 +9,7 @@
 using SabreTools.Serialization.Wrappers;
 using static SabreTools.Data.Models.SecuROM.Constants;
 
+#pragma warning disable IDE0059 // Unnecessary assignment of value
 namespace BinaryObjectScanner.Protection
 {
     // TODO: Investigate SecuROM for Macintosh
diff --git a/BinaryObjectScanner/Protection/StarForce.cs b/BinaryObjectScanner/Protection/StarForce.cs
@@ -8,6 +8,7 @@
 using SabreTools.IO.Matching;
 using SabreTools.Serialization.Wrappers;
 
+#pragma warning disable SYSLIB1045 // Convert to 'GeneratedRegexAttribute'
 namespace BinaryObjectScanner.Protection
 {
     public class StarForce : IDiskImageCheck<ISO9660>, IExecutableCheck<PortableExecutable>, IPathCheck
diff --git a/BinaryObjectScanner/ProtectionProgress.cs b/BinaryObjectScanner/ProtectionProgress.cs
@@ -1,4 +1,5 @@
-﻿namespace BinaryObjectScanner
+﻿#pragma warning disable IDE0290 // Use primary constructor
+namespace BinaryObjectScanner
 {
     /// <summary>
     /// Struct representing protection scanning progress

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System.IO;`
`2`	`2`
	`3`	`+#pragma warning disable IDE0290 // Use primary constructor`
`3`	`4`	`namespace BinaryObjectScanner.FileType`
`4`	`5`	`{`
`5`	`6`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`using BinaryObjectScanner.Interfaces;`
`2`	`2`	`using SabreTools.Serialization.Wrappers;`
`3`	`3`
	`4`	`+#pragma warning disable IDE0290 // Use primary constructor`
`4`	`5`	`namespace BinaryObjectScanner.FileType`
`5`	`6`	`{`
`6`	`7`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`using SabreTools.IO.Extensions;`
`5`	`5`	`using SabreTools.Serialization.Wrappers;`
`6`	`6`
	`7`	`+#pragma warning disable IDE0290 // Use primary constructor`
`7`	`8`	`namespace BinaryObjectScanner.FileType`
`8`	`9`	`{`
`9`	`10`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`using SabreTools.IO.Extensions;`
`7`	`7`	`using SabreTools.Serialization.Wrappers;`
`8`	`8`
	`9`	`+#pragma warning disable IDE0290 // Use primary constructor`
`9`	`10`	`namespace BinaryObjectScanner.FileType`
`10`	`11`	`{`
`11`	`12`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`using SabreTools.Data.Models.ISO9660;`
`8`	`8`	`using SabreTools.IO.Extensions;`
`9`	`9`
	`10`	`+#pragma warning disable IDE0290 // Use primary constructor`
`10`	`11`	`namespace BinaryObjectScanner.FileType`
`11`	`12`	`{`
`12`	`13`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`using System.IO;`
`3`	`3`	`using BinaryObjectScanner.Data;`
`4`	`4`
	`5`	`+#pragma warning disable IDE0290 // Use primary constructor`
`5`	`6`	`namespace BinaryObjectScanner.FileType`
`6`	`7`	`{`
`7`	`8`	`/// <summary>`