test: cover missing cases

Author: lars-reimann

packages/safe-ds-lang/src/language/codeActions/quickfixes/arguments.ts

@@ -14,6 +14,7 @@ export const makeArgumentsAssignedToOptionalParametersNamed = (services: SafeDsS
     return (diagnostic: Diagnostic, document: LangiumDocument, acceptor: CodeActionAcceptor) => {
         const node = locator.getAstNode(document.parseResult.value, diagnostic.data.path);
         if (!isSdsArgumentList(node)) {
+            /* c8 ignore next 2 */
             return;
         }
 
@@ -31,7 +32,6 @@ export const makeArgumentsAssignedToOptionalParametersNamed = (services: SafeDsS
 
 const ensureArgumentIsNamed = (nodeMapper: SafeDsNodeMapper, argument: SdsArgument): TextEdit[] | TextEdit => {
     const cstNode = argument.$cstNode;
-
     if (!cstNode || Argument.isNamed(argument)) {
         return [];
     }

packages/safe-ds-lang/src/language/codeActions/quickfixes/safe-ds-quickfix-provider.ts

@@ -16,23 +16,19 @@ export class SafeDsQuickfixProvider {
 
     createQuickfixes(diagnostic: Diagnostic, document: LangiumDocument, acceptor: CodeActionAcceptor) {
         if (!diagnostic.code) {
+            /* c8 ignore next 2 */
             return;
         }
 
-        const quickfixes = this.registry[diagnostic.code];
-
-        if (Array.isArray(quickfixes)) {
-            for (const quickfix of quickfixes) {
-                quickfix(diagnostic, document, acceptor);
-            }
-        } else if (quickfixes) {
-            quickfixes(diagnostic, document, acceptor);
+        const quickfixes = this.registry[diagnostic.code] ?? [];
+        for (const quickfix of quickfixes) {
+            quickfix(diagnostic, document, acceptor);
         }
     }
 }
 
 type QuickfixRegistry = {
-    [code: string | number]: QuickfixCreator | QuickfixCreator[];
+    [code: string | number]: QuickfixCreator[];
 };
 
 type QuickfixCreator = (diagnostic: Diagnostic, document: LangiumDocument, acceptor: CodeActionAcceptor) => void;

packages/safe-ds-lang/tests/resources/code actions/quickfixes/make arguments assigned to optional parameters named/skip-output/input.sdsdev

@@ -10,9 +10,9 @@ fun myFunction(required: Int, optional1: Int = 0, optional2: Int = 0)
 
 @MyAnnotation(1, optional1 = 2, optional2 = 3, 4)
 
-@MyAnnotation(1, 2, optional2 = 3)
+@MyAnnotation(1, optional1 = 2, optional2 = 3)
 pipeline testPipeline {
     myFunction(1, optional1 = 2, optional2 = 3, 4);
 
-    myFunction(1, 2, optional2 = 3);
+    myFunction(1, optional1 = 2, optional2 = 3);
 }

packages/safe-ds-lang/tests/resources/validation/other/expressions/arguments/must be named if parameter is optional/annotation calls.sdsdev

@@ -12,6 +12,10 @@ annotation MyAnnotation(required: Int, optional1: Int = 0, optional2: Int = 0)
 // $TEST$ no error "Argument must be named if the parameter is optional."
 @MyAnnotation(»1«, »2«, »3«, »4«)
 // $TEST$ no error "Argument must be named if the parameter is optional."
+// $TEST$ error "Argument must be named if the parameter is optional."
+// $TEST$ no error "Argument must be named if the parameter is optional."
+@MyAnnotation(»1«, »2«, »optional2 = 3«)
+// $TEST$ no error "Argument must be named if the parameter is optional."
 // $TEST$ no error "Argument must be named if the parameter is optional."
 @MyAnnotation(»required = 1«, »optional1 = 2«)
 

packages/safe-ds-lang/tests/resources/validation/other/expressions/arguments/must be named if parameter is optional/calls.sdsdev

@@ -12,6 +12,10 @@ pipeline testPipeline {
     // $TEST$ no error "Argument must be named if the parameter is optional."
     myFunction(»1«, »2«, »3«, »4«);
     // $TEST$ no error "Argument must be named if the parameter is optional."
+    // $TEST$ error "Argument must be named if the parameter is optional."
+    // $TEST$ no error "Argument must be named if the parameter is optional."
+    myFunction(»1«, »2«, »optional2 = 3«);
+    // $TEST$ no error "Argument must be named if the parameter is optional."
     // $TEST$ no error "Argument must be named if the parameter is optional."
     myFunction(»required = 1«, »optional1 = 2«);