added missing values for plot

Author: Gerhardsa0

src/safeds/data/tabular/plotting/_table_plotter.py

@@ -392,6 +392,8 @@ def moving_average_plot(self, x_name: str, y_name: str, window_size: int) -> Ima
         import polars as pl
 
         _plot_validation(self._table, x_name, [y_name])
+
+
         # Calculate the moving average
         mean_col = pl.col(y_name).mean().alias(y_name)
         grouped = self._table._lazy_frame.sort(x_name).group_by(x_name).agg(mean_col).collect()
@@ -427,6 +429,10 @@ def _plot_validation(table: Table, x_name: str, y_names: list[str]) -> None:
     _check_columns_exist(table, y_names)
     y_names.remove(x_name)
     _check_columns_are_numeric(table, y_names)
+    y_names.append(x_name)
 
     if not table.get_column(x_name).is_numeric and not table.get_column(x_name).is_temporal:
         raise ColumnTypeError(x_name)
+    for name in y_names:
+        if table.get_column(name).missing_value_count() >= 1:
+            raise ValueError("for plotting there should be no missing values")

tests/safeds/data/tabular/plotting/__snapshots__/test_plot_camparison/test_should_match_snapshot[normal].png

@@ -4,12 +4,14 @@
 from safeds.data.tabular.containers import Table
 from syrupy import SnapshotAssertion
 
+from safeds.exceptions import ColumnNotFoundError, ColumnTypeError
+
 
 @pytest.mark.parametrize(
     ("table", "x_name", "y_name", "window_size"),
     [
         (Table({"A": [1, 2, 3], "B": [2, 4, 7]}), "A", "B", 2),
-        # (Table({"A": [1, 1, 2, 2, 3, 3, 4, 4, 5, 5], "B": [2, 4, 6, 8, 10, 12, 14, 16, 18, 20]}), "A", "B", 2),
+        (Table({"A": [1, 1, 2, 2, 3, 3, 4, 4, 5, 5], "B": [2, 4, 6, 8, 10, 12, 14, 16, 18, 20]}), "A", "B", 2),
         (
             Table(
                 {
@@ -45,7 +47,7 @@
             2,
         ),
     ],
-    ids=["numerical", "date grouped", "date"],
+    ids=["numerical","numerical grouped", "date grouped", "date"],
 )
 def test_should_match_snapshot(
     table: Table,
@@ -56,3 +58,41 @@ def test_should_match_snapshot(
 ) -> None:
     line_plot = table.plot.moving_average_plot(x_name, y_name, window_size)
     assert line_plot == snapshot_png_image
+
+
+@pytest.mark.parametrize(
+    ("x", "y"),
+    [
+        ("C", "A"),
+        ("A", "C"),
+        ("C", "D"),
+    ],
+    ids=["x column", "y column", "x and y column"],
+)
+def test_should_raise_if_column_does_not_exist_error_message(x: str, y: str) -> None:
+    table = Table({"A": [1, 2, 3], "B": [2, 4, 7]})
+    with pytest.raises(ColumnNotFoundError):
+        table.plot.moving_average_plot(x, y, window_size=2)
+
+
+
+
+@pytest.mark.parametrize(
+    ("table"),
+    [
+        (Table({"A": [1, 2, 3], "B": ["2", 4, 7]})),
+        (Table({"A": ["1", 2, 3], "B": [2, 4, 7]})),
+    ],
+    ids=["x column", "y column"],
+)
+
+def test_should_raise_if_column_is_not_numerical(table: Table) -> None:
+    print(table)
+    with pytest.raises(ColumnTypeError):
+        table.plot.moving_average_plot("A", "B", window_size=2)
+
+
+def test_should_raise_if_column_has_missing_value() -> None:
+    table = Table({"A": [None, 2, 3], "B": [2, 4, 7]})
+    with pytest.raises(ValueError):
+        table.plot.moving_average_plot("A", "B", window_size=2)