Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1D Convolutional Layer #853

Open
lars-reimann opened this issue Jun 21, 2024 · 0 comments
Open

1D Convolutional Layer #853

lars-reimann opened this issue Jun 21, 2024 · 0 comments

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Jun 21, 2024

Is your feature request related to a problem?

We only have 2D convolutions so far. 1D convolutions can also be useful, e.g. for time series.

Desired solution

  • Add a new class safeds.ml.nn.layers.Convolutional1DLayer.
  • Superclass: Layer
  • Constructor parameters:
    • output_channel: int
    • kernel_size: int
    • keyword-only stride: int = 1
    • keyword-only padding: int = 0
    • Call _check_bounds to ensure that:
      • output_channel >= 1
      • kernel_size >= 1
      • stride >= 1
      • padding >= 0
  • Implementation:
    • Use PyTorch's Conv1D internally

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

@github-project-automation github-project-automation bot moved this to Backlog in Library Jun 21, 2024
@zogomii zogomii added the team2 label Jun 28, 2024
@TellemHD TellemHD moved this from Backlog to Todo in Library Jun 28, 2024
@TellemHD TellemHD moved this from Todo to In Progress in Library Jun 28, 2024
@TellemHD TellemHD assigned FredericAbels and unassigned JawadFauzi Jul 5, 2024
@TellemHD TellemHD moved this from In Progress to 🧱 Blocked in Library Jul 5, 2024
@lars-reimann lars-reimann removed the lab label Jan 8, 2025
@lars-reimann lars-reimann removed the status in Library Jan 16, 2025
@lars-reimann lars-reimann moved this to Backlog in Library Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants