Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

totalFrame() is one frame less #527

Open
mmaciola opened this issue Sep 5, 2022 · 0 comments
Open

totalFrame() is one frame less #527

mmaciola opened this issue Sep 5, 2022 · 0 comments

Comments

@mmaciola
Copy link
Contributor

mmaciola commented Sep 5, 2022

totalFrame() returns one frame less than should.
It returns the id of the last frame (equal to "op" Out Point), not the total amout of frames.
Comparing to https://lottiefiles.com/tools/json-editor resources are always one frame shorter and different in progress (the same distance in pixels is one frame less, so there is always a small difference in the rendered view).
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 6, 2022
@mmaciola
example: lottieviewer - fixed frame no
628f325 
There is a problem (issue Samsung#527) with totalFrame() in rlottie.
As lottieviewer didn't showed the actual frame number, but calculated it from
progress, it camouflaged the problem. Now the actual frame number and the
total number of frames are displayed.
@mmaciola mmaciola mentioned this issue Sep 6, 2022
Merged
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 14, 2022
@mmaciola
example: lottieviewer - fixed frame no
0a01099 
There is a problem (issue Samsung#527) with totalFrame() in rlottie.
As lottieviewer didn't showed the actual frame number, but calculated it from
progress, it camouflaged the problem. Now the actual frame number and the
total number of frames are displayed.
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 14, 2022
@mmaciola
Fix one frame missing
6c6b5af 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: Samsung#527
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 14, 2022
@mmaciola
Fix one frame missing
1954f72 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: Samsung#527
@mmaciola mmaciola mentioned this issue Sep 14, 2022
Merged
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 14, 2022
@mmaciola
Fix one frame missing
4e5a00d 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.
As there is 0.01 subtract (copied from android implementation, needed
for some resources where frame no is non-whole number), added +2.

issue: Samsung#527
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 15, 2022
@mmaciola
Fix one frame missing
e1875c5 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.
There is 0.01 subtract (copied from android implementation, needed
for some resources where frame no is non-whole number).

issue: Samsung#527
mmaciola added a commit to mmaciola/rlottie that referenced this issue Sep 15, 2022
@mmaciola
Fix one frame missing
8b4f2e6 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: Samsung#527
JSUYA pushed a commit that referenced this issue Sep 19, 2022
@mmaciola
Fix one frame missing (#529)
12facb8 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: #527
JSUYA pushed a commit that referenced this issue Sep 19, 2022
@mmaciola
example: lottieviewer - fixed frame no (#528)
056c0a1 
There is a problem (issue #527) with totalFrame() in rlottie.
As lottieviewer didn't showed the actual frame number, but calculated it from
progress, it camouflaged the problem. Now the actual frame number and the
total number of frames are displayed.
rlaguilar added a commit to rlaguilar/rlottie that referenced this issue Nov 15, 2022
@rlaguilar @JSUYA
@smohantty @xaowang96 @mymedia2 @mmaciola
Include changes from original project (#4)
27ddb37 
* lottiemodel: Improve opacity calculation for gradient stop

Basically, Graeidnt stop's color and opacity are provided as separate arrays.
Stop position and opacity position do not match each other.
Existing code is a sequential approach. It caused problems in various cases of positions.
The improved logic repeats the loop, but no exceptions are raised. It's not complicated, it's simple.

This code referenced the lottie-android library.
https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/parser/GradientColorParser.java

* replace uint ushort and uchar typedefs with uint32 uint16 and uint8
-- added format script to run clang format on latest commit.

* replace unsigned int with uint32_t in Int()

Signed-off-by: wangxuedong <wangxuedong@xiaomi.com>
Change-Id: I4390c12fcf3aefccfe20290436b0dad96877008c

* Add lottie_init() and lottie_shutdown() c api.

To support dynamic loading and unloading of rlottie library safely
we need to deallocate the resource cache as well as safely shutdown all the
worker threads.
current patch only stops the Render and Rle task schedulers when lottie_shutdown is called.

Things yet to be implemented during shutdown phase
- Unload image loader if loaded dynamically.
- Check if we can release some cache resources.
- Currently multiple load and unload of rlottie library will not work as we are not starting the
  scheduler again when lottie_init() called multiple time in the same process.

* add formal parameter void to lottie_init() and lottie_shutdown()

Signed-off-by: wangxuedong <wangxuedong@xiaomi.com>
Change-Id: I40dbe4b07f9581e5042e468d3860e135622580c8

* Ignore animations with objects of unspecified type

* Check border of color table while generating gradient

* Delete accidentally committed Vim swap file

* Fix one frame missing (Samsung#529)

As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: Samsung#527

* example: lottieviewer - fixed frame no (Samsung#528)

There is a problem (issue Samsung#527) with totalFrame() in rlottie.
As lottieviewer didn't showed the actual frame number, but calculated it from
progress, it camouflaged the problem. Now the actual frame number and the
total number of frames are displayed.

Signed-off-by: wangxuedong <wangxuedong@xiaomi.com>
Co-authored-by: JunsuChoi <jsuya.choi@samsung.com>
Co-authored-by: Subhransu Mohanty <sub.mohanty@samsung.com>
Co-authored-by: wangxuedong <wangxuedong@xiaomi.com>
Co-authored-by: Nicholas Guriev <nicholas@guriev.su>
Co-authored-by: Michal Maciola <71131832+mmaciola@users.noreply.github.com>
rlaguilar pushed a commit to rlaguilar/rlottie that referenced this issue Nov 15, 2022
@mmaciola @rlaguilar
Fix one frame missing (Samsung#529)
b851f19 
As mStartFrame and mEndFrame was counted from 0 and totalFrame() was
calculated as a difference, there were always one frame missing and
the animation rescaled. This patch adds one to the total frames count.

issue: Samsung#527
rlaguilar pushed a commit to rlaguilar/rlottie that referenced this issue Nov 15, 2022
@mmaciola @rlaguilar
example: lottieviewer - fixed frame no (Samsung#528)
3a608a6 
There is a problem (issue Samsung#527) with totalFrame() in rlottie.
As lottieviewer didn't showed the actual frame number, but calculated it from
progress, it camouflaged the problem. Now the actual frame number and the
total number of frames are displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmaciola