Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we support idempotent requests? #166

Open
qw-in opened this issue Aug 25, 2022 · 3 comments
Open

Do we support idempotent requests? #166

qw-in opened this issue Aug 25, 2022 · 3 comments
Assignees

Comments

@qw-in
Copy link
Contributor

qw-in commented Aug 25, 2022

https://shopify.dev/api/usage/idempotent-requests

@hillairet
Copy link
Member

No we don't but we certainly should! It seems easy enough.

@hillairet
Copy link
Member

@ponty33 First figure out how it needs to be done and then how SPyLib can handle it.

@ponty33
Copy link
Member

ponty33 commented Aug 10, 2023

  • Only for the following API
    • GraphQL
      • AppRevenueAttributionRecordInput
      • SubscriptionBillingAttemptInput
    • REST
      • Payment
  • It's done by adding unique_token (REST) or idempotencyKey (GraphQL) in the input
    • However I feel it's more of a user's choice, since it's added directly in the input json.
    • If we generate the key inside the execute_rest or execute_gql, wouldn't it use a different key if it's retried by Tenacity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants