src/schemas/json: fix spurious $id definitions

[rogpeppe]

This removes $id definitions from schemas where
those IDs are defining schemas outside of the schema URI itself.

The problem this is fixing is summarized in #4073.

Fixes #4073.

[madskristensen]

@hyperupcall thoughts?

[hyperupcall]

Thanks! At a glance, this looks like a good improvement, similar in style to #3242. I am a little worried about this being a breaking change outside of SchemaStore Schemas. As you mention:

Although there is the possibility that external users are relying on these IDs, I suspect that they're unlikely to be, and if they are, then they should not be.

I somewhat agree, as many of these instances of $id are used either infrequent or inconsistently in schemas. And, the exceptions are in older schemas that haven't received updates in years. But some of the files have specific CODEOWNERS, so I'd like to get their approval before I merge.

cc @skoch13 @andrey-skl @zmaks (JetBrains YouTrack team) What do you think about these changes to youtrack-app.json? As I understand, these changes reduce instances in which $ids are declared outside of their schemas' namespace.

[skoch13]

@hyperupcall looks good to me. Initially these $ids were added in compliance with similar schemes, but they are redundant and can be safely omitted. Thank you!

[hyperupcall]

Awesome, sounds great

[hyperupcall]

@rogpeppe Thanks!