Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Nullstone to the catalog #4153

Closed
wants to merge 3 commits into from

Conversation

BSick7
Copy link
Contributor

@BSick7 BSick7 commented Oct 17, 2024

This adds schema for Nullstone IaC files.

The pre-commit step is failing. I followed the steps in CONTRIBUTING.md, but it modified >2600 files. I didn't think it valuable to change everything in this repo.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Oct 23, 2024

Thanks!

I followed the steps in CONTRIBUTING.md, but it modified >2600 files. I didn't think it valuable to change everything in this repo.

Hmm, maybe your HEAD isn't up to date with origin/HEAD or npm clean-install hasn't been run recently? Very weird that so many files are being locally modified at once with no changes

@BSick7
Copy link
Contributor Author

BSick7 commented Oct 31, 2024

@hyperupcall

When I run local, I get this:

npm run prettier

> schemastore.org@1.0.0 prettier
> prettier --config .prettierrc.cjs --ignore-path .gitignore --check .

Checking formatting...
All matched files use Prettier code style!

@hyperupcall
Copy link
Member

Sorry for the trouble, pre-commit.ci has been giving us this issue with Prettier for a while now. It doesn't seem to like the files .prettierrc.yml and .prettierrc.json in particular. I couldn't edit your branch, so I've created #4193 so this could be fixed. Is it OK for merge?

@BSick7
Copy link
Contributor Author

BSick7 commented Nov 5, 2024

Sorry for the trouble, pre-commit.ci has been giving us this issue with Prettier for a while now. It doesn't seem to like the files .prettierrc.yml and .prettierrc.json in particular. I couldn't edit your branch, so I've created #4193 so this could be fixed. Is it OK for merge?

Thanks @hyperupcall! Merge away!

@BSick7 BSick7 closed this Nov 5, 2024
@BSick7 BSick7 deleted the nullstone branch November 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants