Skip to content

Commit ce34136

Browse files
feat(OnyxBottomBar): Implement screenshot tests (#2402)
<!-- Is your PR related to an issue? Then please link it via the "Relates to #" below. Else, remove it. --> Relates to #2290 - Implement screenshot tests - Add example in the demo app ## Checklist - [x] If a new component is added, at least one [Playwright screenshot test](https://github.com/SchwarzIT/onyx/actions/workflows/playwright-screenshots.yml) is added --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent b8aaff8 commit ce34136

File tree

6 files changed

+57
-1
lines changed

6 files changed

+57
-1
lines changed

apps/demo-app/src/views/HomeView.vue

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {
55
DENSITIES,
66
OnyxAvatar,
77
OnyxBadge,
8+
OnyxBottomBar,
89
OnyxButton,
910
OnyxCheckboxGroup,
1011
OnyxDatePicker,
@@ -321,6 +322,14 @@ const selectedDate = ref<DateValue>();
321322
<!-- Add new components alphabetically. -->
322323
</div>
323324
</div>
325+
<template #footer>
326+
<OnyxBottomBar>
327+
<template #right>
328+
<OnyxButton label="Button" mode="plain" color="neutral"></OnyxButton>
329+
<OnyxButton label="Button"></OnyxButton>
330+
</template>
331+
</OnyxBottomBar>
332+
</template>
324333
</OnyxPageLayout>
325334
</template>
326335

Loading
Loading
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
import { test } from "../../playwright/a11y";
2+
import { executeMatrixScreenshotTest } from "../../playwright/screenshots";
3+
import OnyxButton from "../OnyxButton/OnyxButton.vue";
4+
import OnyxBottomBar from "./OnyxBottomBar.vue";
5+
6+
test.describe("Screenshot tests", () => {
7+
executeMatrixScreenshotTest({
8+
name: "Bottom Bar",
9+
columns: ["default", "hidden-border"],
10+
rows: ["right", "left", "left-and-right"],
11+
component: (column, row) =>
12+
row === "left-and-right" ? (
13+
<OnyxBottomBar hideBorder={column === "hidden-border"}>
14+
<template v-slot:left>
15+
<OnyxButton label="Button"></OnyxButton>
16+
</template>
17+
<template v-slot:right>
18+
<OnyxButton label="Button" mode="plain" color="neutral"></OnyxButton>
19+
<OnyxButton label="Button"></OnyxButton>
20+
</template>
21+
</OnyxBottomBar>
22+
) : row === "right" ? (
23+
<OnyxBottomBar hideBorder={column === "hidden-border"}>
24+
<template v-slot:right>
25+
<OnyxButton label="Button" mode="plain" color="neutral"></OnyxButton>
26+
<OnyxButton label="Button"></OnyxButton>
27+
</template>
28+
</OnyxBottomBar>
29+
) : (
30+
<OnyxBottomBar hideBorder={column === "hidden-border"}>
31+
<template v-slot:left>
32+
<OnyxButton label="Button" mode="plain" color="neutral"></OnyxButton>
33+
<OnyxButton label="Button"></OnyxButton>
34+
</template>
35+
</OnyxBottomBar>
36+
),
37+
hooks: {
38+
beforeEach: async (component, page) => {
39+
await component.evaluate((element) => {
40+
element.style.padding = "5rem 0";
41+
element.style.paddingRight = "25rem";
42+
});
43+
await page.setViewportSize({ width: 400, height: 100 });
44+
},
45+
},
46+
});
47+
});

packages/sit-onyx/src/components/OnyxBottomBar/OnyxBottomBar.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const { densityClass } = useDensity(props);
4343
4444
.onyx-bottom-bar {
4545
@include layers.component() {
46-
position: fixed;
46+
position: sticky;
4747
bottom: 0;
4848
width: 100%;
4949
margin-inline: var(--onyx-grid-margin-inline);

0 commit comments

Comments
 (0)