Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend topics related to release-jobs #1590

Open
despadam opened this issue Sep 16, 2024 · 4 comments
Open

Frontend topics related to release-jobs #1590

despadam opened this issue Sep 16, 2024 · 4 comments
Assignees

Comments

@despadam
Copy link

despadam commented Sep 16, 2024

  • Discuss with site that uses the files property whether changing
 job.datasetList = {
              pid: "",
              files: [],
            }

to job.datasetIds = ["pid1", "pid2" ] would still work for them (see src/app/datasets/admin-tab/admin-tab.component.ts)

  • JobClass extends OwnableClass, but is field isPublished needed for a job?

  • Should ownerUser in the Job schema be renamed to owner (to match Dataset.owner) and should it be required?

  • Up to now I think the backend was backwards-compatible with v3. We should clearly indicate in the README that it requires scicat-backend-next.

_Originally posted by @sbliven in #1585

@despadam despadam self-assigned this Sep 16, 2024
@despadam despadam changed the title Topics related to release-jobs Frontend topics related to release-jobs Sep 16, 2024
@despadam
Copy link
Author

despadam commented Oct 3, 2024

Actions:

  • We mark isPublished fields as optional in the fe
  • Preserve the ownerUser field in Job Schema, as it checked and must be a valid SciCat user, while the owner in the Dataset schema can be any string. Naming them differently signifies this difference. Lastly, ownerUser should be a required field
  • Roll back to using datasetList

@sofyalaski
Copy link

I think the logic was that the ownerUser is not a required property. For instance, admin can create a job for someone and it need not be restricted to a specific user but just a group.

@despadam
Copy link
Author

PR: #1616

@despadam
Copy link
Author

TODO: #1619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants