Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Nov 24, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Rework current structure to be more flexible and similar between models
  • Define functions for each type of epidata setter, that works on a single region
  • Use graph for setting epidata

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@MaxBetzDLR MaxBetzDLR requested a review from HenrZu November 24, 2025 09:35
@MaxBetzDLR MaxBetzDLR self-assigned this Nov 24, 2025
@MaxBetzDLR MaxBetzDLR added the class::improvement Cleanup that doesn't affect functionality label Nov 24, 2025
@MaxBetzDLR MaxBetzDLR linked an issue Nov 24, 2025 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 94.48560% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.30%. Comparing base (edb7428) to head (d6f9906).

Files with missing lines Patch % Lines
cpp/models/ode_secirts/parameters_io.h 56.14% 25 Missing ⚠️
cpp/models/ode_secirvvs/parameters_io.cpp 97.11% 13 Missing ⚠️
cpp/models/ode_secirts/parameters_io.cpp 97.50% 10 Missing ⚠️
cpp/models/ode_secirvvs/parameters_io.h 82.69% 9 Missing ⚠️
cpp/models/ode_secir/parameters_io.cpp 96.36% 8 Missing ⚠️
cpp/memilio/io/parameters_io.cpp 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.01%     
==========================================
  Files         187      187              
  Lines       16018    15820     -198     
==========================================
- Hits        15588    15394     -194     
+ Misses        430      426       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::improvement Cleanup that doesn't affect functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve parameters IO for graph ODE-based models

3 participants