Set edge_color in plot_complexes regardless of whether edge labels are shown or not
#1345
Conversation
…s are shown or not
|
@devmotion thanks! Looks like there is some kind of CI issue currently. I'll make a release with the current master as this isn't a critical issue, and then we can make another release once this is merged. That way we stop holding people up from using Makie. |
|
Hmmm... These CI errors seem very weird and completely unrelated: https://github.com/SciML/Catalyst.jl/actions/runs/19835077827/job/56830272189?pr=1345#step:6:449 Maybe it's a general GHA problem right now? In that case, CI would fail on master as well in the same way. So I'm not sure if it's worth rushing a new release, I think most likely these tests will pass went they are rerun. |
|
In particular, given that it took 3 weeks until #1337 could be merged, I don't think a few hours more will matter. |
|
The relevant extension test set already passes, so the PR doesn't seem to cause any test failures: https://github.com/SciML/Catalyst.jl/actions/runs/19835077827/job/56830272071?pr=1345 The docs build should show whether it works as intended. |
|
Yeah, they are quite weird errors. In any case I already started the release, but once this is merged I'll just make another. I don't think it is a big deal to lose the coloring in one (hopefully) short-lived release. |
|
Thanks! |
Fixes #1344.