return correct variable type/metadata in map_symbolics_ident #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 94.11% 93.94% -0.17%
==========================================
Files 6 7 +1
Lines 323 347 +24
==========================================
+ Hits 304 326 +22
- Misses 19 21 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 9 commits
July 15, 2023 17:36
SebastianM-C
approved these changes
Jul 19, 2023
src/utils.jl
Outdated
Comment on lines
10
to
13
| # map_symbolics_ident(x) = begin | ||
| # sym = Symbol(x.id) | ||
| # first(@species $sym) | ||
| # end |
There was a problem hiding this comment.
is this still needed?
added 2 commits
July 19, 2023 18:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an initialAssignment contains a species instead of a parameter, this species needs to be a function of
tsuch that it can be substituted with the defaults.