From 088887454d1511e74cb37010f3db6a6abcc71dd2 Mon Sep 17 00:00:00 2001
From: Jicheng Lu <franklujc@gmail.com>
Date: Mon, 12 Aug 2024 21:11:13 -0500
Subject: [PATCH] refine search list

---
 src/lib/scss/custom/pages/_knowledgebase.scss |  4 +++
 .../knowledge-search-list.svelte              | 27 ++++---------------
 .../knowledge-search/knowledge-search.svelte  | 17 ++++++++----
 3 files changed, 21 insertions(+), 27 deletions(-)

diff --git a/src/lib/scss/custom/pages/_knowledgebase.scss b/src/lib/scss/custom/pages/_knowledgebase.scss
index 0dedf8f..12e91ba 100644
--- a/src/lib/scss/custom/pages/_knowledgebase.scss
+++ b/src/lib/scss/custom/pages/_knowledgebase.scss
@@ -35,6 +35,10 @@
     }
 
     .knowledge-search-result-container {
+        li::marker {
+            color: var(--bs-secondary)
+        }
+
         .list-open {
             list-style-type: disclosure-open;
         }
diff --git a/src/routes/page/knowledge-base/knowledge-search/knowledge-search-list.svelte b/src/routes/page/knowledge-base/knowledge-search/knowledge-search-list.svelte
index 8a7e2f6..34d702f 100644
--- a/src/routes/page/knowledge-base/knowledge-search/knowledge-search-list.svelte
+++ b/src/routes/page/knowledge-base/knowledge-search/knowledge-search-list.svelte
@@ -1,31 +1,14 @@
 <script>
-  import LoadingDots from '$lib/common/LoadingDots.svelte';
 	import KnowledgeSearchItem from './knowledge-search-item.svelte';
   
   /** @type {import('$types').KnowledgeRetrivalViewModel[]} */
   export let list;
-
-  /** @type {boolean} */
-  export let isSearching = false;
-
-  /** @type {boolean} */
-  export let searchDone = false;
 </script>
 
 <div class="knowledge-search-result-container">
-  {#if list?.length > 0}
-    <ul>
-      {#each list as item, idx (idx)}
-        <KnowledgeSearchItem item={item} open={idx === 0} />
-      {/each}
-    </ul>
-  {:else if isSearching}
-    <div class="knowledge-loader mt-4">
-      <LoadingDots duration={'1s'} size={12} gap={5} color={'var(--bs-primary)'} />
-    </div>
-  {:else if searchDone}
-    <div class="mt-2">
-      <h3 class="text-secondary">{"Ehhh, no idea..."}</h3>
-    </div>
-  {/if}
+  <ul>
+    {#each list as item, idx (idx)}
+      <KnowledgeSearchItem item={item} open={idx === 0} />
+    {/each}
+  </ul>
 </div>
\ No newline at end of file
diff --git a/src/routes/page/knowledge-base/knowledge-search/knowledge-search.svelte b/src/routes/page/knowledge-base/knowledge-search/knowledge-search.svelte
index 73e32b4..e26bc30 100644
--- a/src/routes/page/knowledge-base/knowledge-search/knowledge-search.svelte
+++ b/src/routes/page/knowledge-base/knowledge-search/knowledge-search.svelte
@@ -1,6 +1,7 @@
 <script>
 	import { searchKnowledge } from "$lib/services/knowledge-base-service";
   import { Button } from "@sveltestrap/sveltestrap";
+  import LoadingDots from "$lib/common/LoadingDots.svelte";
 	import KnowledgeSearchList from "./knowledge-search-list.svelte";
   import _ from "lodash";
 
@@ -66,9 +67,15 @@
     </Button>
   </div>
 
-  <KnowledgeSearchList
-    list={search_results}
-    isSearching={is_searching}
-    searchDone={search_done}
-  />
+  {#if is_searching}
+    <div class="knowledge-loader mt-4">
+      <LoadingDots duration={'1s'} size={12} gap={5} color={'var(--bs-primary)'} />
+    </div>
+  {:else if search_results?.length > 0}
+    <KnowledgeSearchList list={search_results} />
+  {:else if search_done}
+    <div class="mt-2">
+      <h4 class="text-secondary">{"Ehhh, no idea..."}</h4>
+    </div>
+  {/if}
 </div>
\ No newline at end of file