Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded path in KerasLayer.cs #10

Open
dharmeshtailor opened this issue Nov 14, 2023 · 1 comment
Open

Hardcoded path in KerasLayer.cs #10

dharmeshtailor opened this issue Nov 14, 2023 · 1 comment

Comments

@dharmeshtailor
Copy link

dharmeshtailor commented Nov 14, 2023

In this file, the module path is hardcoded to "C:\Users\haipi\AppData\Local\Temp\tfhub_modules\602d30248ff7929470db09f7385fc895e9ceb4c0"

SciSharp.Models.Core/TensorflowHub/KerasLayer.cs
https://github.com/SciSharp/SciSharp.Models/blob/master/SciSharp.Models.Core/TensorflowHub/KerasLayer.cs

I cannot use it because of this. Although the work around is to create that directory structure.

@zacuke
Copy link

zacuke commented Oct 19, 2024

There is other hardcoded things, for example in the file SciSharp.Models.TimeSeries/BaselineModel.cs the column name for the WeatherPrediction example shows up.
var baseline = new Baseline(_window.GetColumnIndex("T (degC)"));

I think there should be a ReadMe added to this repo so people know that it's meant to be used as example, and not referenced directly in projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants