Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Save Layout dialog component #17

Closed
pling-scottlogic opened this issue Aug 4, 2023 · 0 comments · Fixed by #29
Closed

Create Save Layout dialog component #17

pling-scottlogic opened this issue Aug 4, 2023 · 0 comments · Fixed by #29
Assignees
@pling-scottlogic @vferraro-scottlogic
Labels
feature
Milestone
Layout Management

Comments

@pling-scottlogic
Copy link

pling-scottlogic commented Aug 4, 2023 •
edited by vferraro-scottlogic
Loading

Background

As part of the Layout Management Issue, we want to build a modal component to allow users to save their current layout.

Work Required

Edit the placeholder component SaveLayoutPanel.tsx to match the Figma design (Save Layout 2 > Save Modal w/Overlay > Frame 108)

Testing

Write unit tests (using react-testing-library) for the new component.

Notes
@pling-scottlogic pling-scottlogic mentioned this issue Aug 7, 2023
Closed
@cfisher-scottlogic cfisher-scottlogic added this to the Layout Management milestone Aug 14, 2023
@cfisher-scottlogic cfisher-scottlogic changed the title Create save dialog component Create Save Layout dialog component Aug 14, 2023
@cfisher-scottlogic cfisher-scottlogic mentioned this issue Aug 23, 2023
Merged
@pling-scottlogic pling-scottlogic mentioned this issue Aug 25, 2023
Merged
@pling-scottlogic pling-scottlogic linked a pull request Aug 29, 2023 that will close this issue
#17 Add Save Layout UI Component #29
Merged
@vferraro-scottlogic vferraro-scottlogic mentioned this issue Sep 1, 2023
Closed
pling-scottlogic added a commit that referenced this issue Sep 1, 2023
@pling-scottlogic
Merge pull request #29 from ScottLogic/feature/VUU-17-layoutSave
7f66f86 
#17 Add Save Layout UI Component
@pling-scottlogic pling-scottlogic mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pling-scottlogic pling-scottlogic

@vferraro-scottlogic vferraro-scottlogic

Labels
feature
Projects
None yet
Milestone
Layout Management
Development

Successfully merging a pull request may close this issue.

#17 Add Save Layout UI Component ScottLogic/finos-vuu
3 participants
@pling-scottlogic @vferraro-scottlogic @cfisher-scottlogic