Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification check for minimum screenpy dependency #49

Open
bandophahita opened this issue Feb 14, 2024 · 0 comments
Open

Add verification check for minimum screenpy dependency #49

bandophahita opened this issue Feb 14, 2024 · 0 comments

Comments

@bandophahita
Copy link
Contributor

bandophahita commented Feb 14, 2024

It occurred to me as I was reviewing a PR that we don't currently have a check to ensure screenpy_selenium works with the minimum screenpy version supported.

Example: we consolidated namespaces in screenpy so nearly everything could be imported directly from the root.
If screenpy_selenium supported a version of screenpy prior to that consolidation but proceeded to import everything as if it assumed they could be found at the root, users would get import errors.

I'm thinking we could create a specific tox environment (?) where we specifically install the oldest supported screenpy and run tests/linters/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant