Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard BS modal #8

Open
mila76 opened this issue Jan 15, 2022 · 1 comment
Open

Standard BS modal #8

mila76 opened this issue Jan 15, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mila76
Copy link

mila76 commented Jan 15, 2022

I can't create a "standard" modal (like the ones in boostrap doc) because in modal-header we have border-0 and style.main and in modal-footer style.border. This need to be empty for the standard layout

Maybe registering a new Style is possible to fix but i think is a function needed in default styles

@Script47
Copy link
Owner

@mila76

Yes - I see your point.

The original intent I had when I added border-0 by default was to make the colors merge better and to also remove a redundant border. I feel that this should be left up to the developer to decide.

In the meantime, to get the "standard" style, you can register and use the following style:

Bs5Utils.registerStyle('default', {
    btnClose: [],
    main: ['border-bottom'],
    border: []
});

which will output a modal as:

image

Live Example: https://jsfiddle.net/uekan6tb/2/

@Script47 Script47 added the enhancement New feature or request label Jan 16, 2022
@Script47 Script47 self-assigned this Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants