Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer group.id should not be set #4

Open
loicmathieu opened this issue Dec 16, 2020 · 3 comments
Open

Consumer group.id should not be set #4

loicmathieu opened this issue Dec 16, 2020 · 3 comments
Assignees

Comments

@loicmathieu
Copy link

Consumer group.id should not be set by default.
When you launch a scenario a first with a consumer group set via group.id Kafka will register the offset read by this consumer group.
If you launch the same scenario some times later, Kafka will send you all the messages sent between the two launch of the scenario.

This is usually not what to do for a end to end test perspective when you're only interested on the messages send during your scenario.

So I propose to not set consumer group.id by default.

@loicmathieu
Copy link
Author

In fact, you must se group.id to avoid commiting offset on a topic enable.auto.commit should be set to false by default.
This will allow to have idempotent scenario.

@Sdaas
Copy link
Owner

Sdaas commented Dec 23, 2020

Consumer group.id should not be set by default.
When you launch a scenario a first with a consumer group set via group.id Kafka will register the offset read by this consumer group.
If you launch the same scenario some times later, Kafka will send you all the messages sent between the two launch of the scenario.

This is usually not what to do for a end to end test perspective when you're only interested on the messages send during your scenario.

So I propose to not set consumer group.id by default.

Good point. Thanks for the feedback .

@Sdaas Sdaas self-assigned this Dec 23, 2020
@loicmathieu
Copy link
Author

I can provide a PR if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants