From 4bad1a80b83dc399da6d46f89643854953ccae8a Mon Sep 17 00:00:00 2001 From: Georges Berenger Date: Sat, 10 Aug 2024 00:36:27 -0700 Subject: [PATCH] Provide more details about the record we could not read Summary: When we fail to read a record, it can be useful to log more about the record that failed. Reviewed By: maxouellet Differential Revision: D60998889 fbshipit-source-id: f716e35383b64d4f0d252935c981ca0144e35033 --- vrs/RecordFileReader.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vrs/RecordFileReader.cpp b/vrs/RecordFileReader.cpp index 31f75b09..62c6c3c1 100644 --- a/vrs/RecordFileReader.cpp +++ b/vrs/RecordFileReader.cpp @@ -1174,7 +1174,13 @@ int RecordFileReader::readRecord( error = reader->read(dataReference, readSize); if (error != 0) { reader->finish(); - XR_LOGE("Read failed: {}", errorCodeToMessageWithCode(error)); + XR_LOGE( + "Reading {} record #{} failed. Stream {} @ {:.3f}: {}", + toString(recordInfo.recordType), + getRecordIndex(&recordInfo), + recordInfo.streamId.getNumericName(), + recordInfo.timestamp, + errorCodeToMessageWithCode(error)); return error; } }