Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making the saved games real PGN files #79

Open
DrBrask opened this issue Jul 21, 2023 · 3 comments
Open

Consider making the saved games real PGN files #79

DrBrask opened this issue Jul 21, 2023 · 3 comments

Comments

@DrBrask
Copy link

DrBrask commented Jul 21, 2023

The only thing that seems to be missing is the result marker at the end of the movetext.

Also consider not saving the first empty DrawByArbiter game that is always there.

If this is fixed and the games are saved with the PGN extension instead of txt the games can then be opened in programs like Arena.

See the end of the "movetext" section here:
Wikipedia on the PGN format

Actual PGN spec

@audiBookning
Copy link

That would be an interesting addition. And the FEN files could have similar changes.
Though one should note that most chess program normally give also the option to open txt files as pgn.

Also note that this program doesn't follow exactly the standard since it has cases like [Result "Repetition"] which suggest that "standard format" may not be the intended use.
Another note is that i don't know about Arena but most chess applications recognize that pgn is not a standard that people enforce very strictly historically wise. So chess apps usually give some leeway when dealing with incompatibilities in pgn.

@mrgwbland
Copy link

Sorry it's not really relevant but where are the games saved/ how do I save them?

@audiBookning
Copy link

audiBookning commented Jul 24, 2023

edit: made a mistake in my assumptions.
To save the games you just have to click on the save button but it seem that at this time it will only save games that have been completed. That is, including bot vs bot games and also your own game when it has ended.

To games are saved in your {AppFolder}/ChessCodingChallenge/games. That directory will change depending on your OS. There are different manners to find it but in this case it is easy.
The game prints the whole path in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants