-
-
Notifications
You must be signed in to change notification settings - Fork 2
bug: combat turn returns success=false, damage=0, empty description on every call #718
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinggame-engineGame mechanics/rulesGame mechanics/rulespriority:criticalBlocking/broken functionalityBlocking/broken functionality
Description
Summary
POST /combat/{combat_id}/turn consistently returns:
{"combat_id": "...", "success": false, "damage": 0, "description": "", "next_turn": true}success: falseon every turn — no actions ever succeeddamage: 0— no damage is ever dealtdescription: ""— empty narrationtarget_id: null— target is not resolved
This is because CombatMCAgent.start_combat() is never called (see #707), so encounters remain in 'ready' state and action processing fails silently, returning the default empty result object.
Repro
POST /game/combat/initialize {"character_ids": ["char_id"], "enemies": [...]}
POST /game/combat/{combat_id}/turn {"character_id": "char_id", "action": "attack", "target": "Goblin"}
# Returns success=false, damage=0, description=''Root Cause
Same as #706, #707 — combat system is fully broken end-to-end.
Files
backend/app/api/routes/combat_routes.py—process_turn()backend/app/agents/combat_mc_agent.py—process_combat_action()
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggame-engineGame mechanics/rulesGame mechanics/rulespriority:criticalBlocking/broken functionalityBlocking/broken functionality