Skip to content

bug: combat turn returns success=false, damage=0, empty description on every call #718

@Sealjay

Description

@Sealjay

Summary

POST /combat/{combat_id}/turn consistently returns:

{"combat_id": "...", "success": false, "damage": 0, "description": "", "next_turn": true}
  • success: false on every turn — no actions ever succeed
  • damage: 0 — no damage is ever dealt
  • description: "" — empty narration
  • target_id: null — target is not resolved

This is because CombatMCAgent.start_combat() is never called (see #707), so encounters remain in 'ready' state and action processing fails silently, returning the default empty result object.

Repro

POST /game/combat/initialize {"character_ids": ["char_id"], "enemies": [...]}
POST /game/combat/{combat_id}/turn {"character_id": "char_id", "action": "attack", "target": "Goblin"}
# Returns success=false, damage=0, description=''

Root Cause

Same as #706, #707 — combat system is fully broken end-to-end.

Files

  • backend/app/api/routes/combat_routes.pyprocess_turn()
  • backend/app/agents/combat_mc_agent.pyprocess_combat_action()

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggame-engineGame mechanics/rulespriority:criticalBlocking/broken functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions