Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout handling #100

Open
marcorondong opened this issue Oct 1, 2024 · 1 comment
Open

Timeout handling #100

marcorondong opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@marcorondong
Copy link
Collaborator

Currently, we close the connection when client reach timeout.
(That causes one of our test to fail)

  1. We should check time and if client timed ot, we shoudl send a response with:
  • When client is requesting something: 408 Request Timeout.
  • When ccgi is running and it timed out: 504 Gateway Timeout.
  1. We also should send the header field "Connection: close" so the user-agent close the connection.
  2. Client's time should be refreshed when it request something new.
@marcorondong marcorondong added the bug Something isn't working label Oct 1, 2024
@gabrieldanis gabrieldanis self-assigned this Oct 4, 2024
@Sekula34
Copy link
Owner

In that case Nginx doesnt send 408, 504 we send.

  1. We maybe should close every time since we are not supporting keep alive
  2. Make sense in keep alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants