Skip to content

CI: Windows test failures (pre-existing) #15

@scottsen

Description

@scottsen

Summary

Windows CI tests have pre-existing failures unrelated to recent releases. These were surfaced after fixing macOS CI issues in v0.42.0.

Failures (22 total on Python 3.10 Windows)

PermissionError - Temp file cleanup (14 tests)

Files still in use when cleanup runs:

  • test_diff_adapter.py - 6 tests
  • test_nginx_analyzer_pytest.py - 3 tests
  • test_ordinal_extraction.py - 2 tests
  • test_sqlite_adapter.py - 1 test

UnicodeDecodeError - Encoding issues (4 tests)

Windows charmap codec can't decode certain bytes:

  • test_documentation_validation.py - 2 tests
  • test_registry_integrity.py - 2 tests

Path separator issues (3 tests)

Forward slash vs backslash in paths:

  • test_v022_package_manifest.py - 3 tests (reveal/docs vs reveal\\docs)

Other (1 test)

  • test_file_checker.py::test_gitignore_read_error - Logic issue
  • test_rules.py::test_in_tests_directory_allowed - Path detection

Suggested Fixes

  1. PermissionError: Use tempfile.TemporaryDirectory context manager, add retry logic for cleanup
  2. UnicodeDecodeError: Explicitly specify encoding='utf-8' when reading files
  3. Path separators: Use pathlib or os.path.join instead of hardcoded /

Priority

Low - Ubuntu and macOS CI pass, Windows is optional for this project.

Related

  • Commit 822521c fixed macOS CI issues
  • v0.42.0 release is stable

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions