clean up update() and delete(), both will now be compatible with named and numbered arguments

resolves #54

Author: SergeyTsalkov

db.class.php

@@ -308,14 +308,15 @@ public function update() {
     $args = func_get_args();
     $table = array_shift($args);
     $params = array_shift($args);
-    $where = array_shift($args);
-    
-    $query = str_replace('%', $this->param_char, "UPDATE %b SET %hc WHERE ") . $where;
-    
-    array_unshift($args, $params);
-    array_unshift($args, $table);
-    array_unshift($args, $query);
-    return call_user_func_array(array($this, 'query'), $args);
+
+    $update_part = $this->parseQueryParams(
+      str_replace('%', $this->param_char, "UPDATE %b SET %hc"),
+      $table, $params
+    );
+
+    $where_part = call_user_func_array(array($this, 'parseQueryParams'), $args);
+    $query = $update_part . ' WHERE ' . $where_part;
+    return $this->query($query);
   }
 
   public function insertOrReplace($which, $table, $datas, $options=array()) {
@@ -387,10 +388,10 @@ public function insertUpdate() {
   public function delete() {
     $args = func_get_args();
     $table = $this->formatTableName(array_shift($args));
-    $where = array_shift($args);
-    $buildquery = "DELETE FROM $table WHERE $where";
-    array_unshift($args, $buildquery);
-    return call_user_func_array(array($this, 'query'), $args);
+
+    $where = call_user_func_array(array($this, 'parseQueryParams'), $args);
+    $query = "DELETE FROM {$table} WHERE {$where}";
+    return $this->query($query);
   }
 
   public function sqleval() {

simpletest/BasicTest.php

@@ -23,6 +23,11 @@ function test_1_create_table() {
     `id` INT NOT NULL AUTO_INCREMENT PRIMARY KEY ,
     `signature` VARCHAR( 255 ) NULL DEFAULT 'donewriting'
     ) ENGINE = InnoDB");
+
+    DB::query("CREATE TABLE `fake%s_table` (
+    `id` INT NOT NULL AUTO_INCREMENT PRIMARY KEY ,
+    `name` VARCHAR( 255 ) NULL DEFAULT 'blah'
+    ) ENGINE = InnoDB");
 
     $mysqli = DB::get();
     DB::disconnect();
@@ -162,12 +167,12 @@ function test_4_query() {
     $this->assert($columnlist[5] === 'height');
 
     $tablelist = DB::tableList();
-    $this->assert(count($tablelist) === 2);
+    $this->assert(count($tablelist) === 3);
     $this->assert($tablelist[0] === 'accounts');
 
     $tablelist = null;
     $tablelist = DB::tableList(DB::$dbName);
-    $this->assert(count($tablelist) === 2);
+    $this->assert(count($tablelist) === 3);
     $this->assert($tablelist[0] === 'accounts');
   }
 
@@ -186,7 +191,7 @@ function test_4_1_query() {
     $true = DB::update('accounts', array(
       'password' => DB::sqleval("REPEAT('blah', %i)", 4),
       'favorite_word' => null,
-      ), 'username=%s', 'newguy');
+      ), 'username=%s_name', array('name' => 'newguy'));
 
     $row = null;
     $row = DB::queryOneRow("SELECT * FROM accounts WHERE username=%s", 'newguy');
@@ -414,7 +419,16 @@ function test_901_updatewithspecialchar() {
     DB::update('profile',array('signature'=> "%li "),"id = %d",1);
     $signature = DB::queryFirstField("SELECT signature FROM profile WHERE id=%i", 1);
     $this->assert($signature === "%li ");
+  }
 
+  function test_902_faketable() {
+    DB::insert('fake%s_table', array('name' => 'karen'));
+    $count = DB::queryFirstField("SELECT COUNT(*) FROM %b", 'fake%s_table');
+    $this->assert($count === '1');
+    DB::update('fake%s_table', array('name' => 'haren%s'), 'name=%s_name', array('name' => 'karen'));
+    DB::delete('fake%s_table', 'name=%s0', 'haren%s');
+    $count = DB::queryFirstField("SELECT COUNT(*) FROM %b", 'fake%s_table');
+    $this->assert($count === '0');
   }