Skip to content

Commit e6c19be

Browse files
authored
Merge pull request #200 from ServiceNow/mass_patch_1
small API change - passing exp_root to study.run()
2 parents 6d2b1ea + 53a395c commit e6c19be

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/agentlab/experiments/study.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,12 +298,13 @@ def run(
298298
strict_reproducibility=False,
299299
n_relaunch=3,
300300
relaunch_errors=True,
301+
exp_root=RESULTS_DIR,
301302
):
302303

303304
self.set_reproducibility_info(
304305
strict_reproducibility=strict_reproducibility, comment=self.comment
305306
)
306-
self.save()
307+
self.save(exp_root=exp_root)
307308

308309
n_exp = len(self.exp_args_list)
309310
last_error_count = None
@@ -461,15 +462,22 @@ def find_incomplete(self, include_errors=True):
461462
for study in self.studies:
462463
study.find_incomplete(include_errors=include_errors)
463464

464-
def run(self, n_jobs=1, parallel_backend="ray", strict_reproducibility=False, n_relaunch=3):
465+
def run(
466+
self,
467+
n_jobs=1,
468+
parallel_backend="ray",
469+
strict_reproducibility=False,
470+
n_relaunch=3,
471+
exp_root=RESULTS_DIR,
472+
):
465473

466474
# This sequence of of making directories is important to make sure objects are materialized
467475
# properly before saving. Otherwise relaunch may not work properly.
468476
self.make_dir()
469477
for study in self.studies:
470478
study.make_dir(exp_root=self.dir)
471479

472-
self.save()
480+
self.save(exp_root=exp_root)
473481
self._run(n_jobs, parallel_backend, strict_reproducibility, n_relaunch)
474482
_, summary_df, _ = self.get_results()
475483
logger.info("\n" + str(summary_df))

0 commit comments

Comments
 (0)