Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tags feature for AA framework #238

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

riyasuntwal
Copy link
Contributor

@riyasuntwal riyasuntwal commented Feb 19, 2025

Changes:
Update the create consent and get Consent API request payload and response to include tags - Account Aggregator Consent flow — Setu Docs as -

"additionalParams": { // New Field
		"tags": [<List of Restricted Values only>]
	}  

Added context for tags finctionality in AA framework here as well - Account Aggregator consent object — Setu Docs

Attaching some screenshots of the changes reviewed from MDX-preview feature :
image
image
image
image
image
image
image

Added the change for removing list for single element in error messages column under data fetch API. Attaching a screenshot below of before/After :
image
image

Copy link

github-actions bot commented Feb 19, 2025

Checklist to merge a PR 🚀

To merge this pull request, please take time to complete the checklist.

What action did you perform?

Review the corresponding checklist items for the action you performed and mark them done.

Edit an existing content (MDX) page

Checklist

  • Review changes using the MDX preview option
  • If the length of content >15000 chars, use the Content preview portal to view changes
  • If a redirect is needed to the existing page, add a key, value pair in redirects.json

Edit an existing API reference page

Checklist


Add a new content (MDX) page

Checklist

  • Create a .mdx file with the path as its name in the content folder
  • Add frontmatter with all the metadata
  • Review the order of items in Sidebar using the Sidebar preview option
  • Review changes using the MDX preview option
  • If the length of content >15000 chars, use the Content preview portal to view changes
  • Created a folder with the same name, if any children were to be added to the page
  • Once all changes are done, update the menu items by using the Menu Items option
  • Add a key, and value pair in redirects.json if you wish to have a redirect to the new page

Add a new API reference page

Checklist

  • Create a .json file with the product path as its name
  • Create an api-reference.mdx file in the respective product folder inside content folder
  • Add frontmatter with all the metadata
  • Review the order of items in Sidebar using the Sidebar preview option
  • Add API reference in JSON format (OpenAPI or Swagger) into created .json file.
  • Used the Content preview portal to view changes
  • Once all changes are done, update the menu items by using the Menu Items option

@@ -18,6 +18,12 @@ Consent object contains the information about all the different types of data th

<br />

<Callout type="info">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no type info for Callout, we have tip. I'll update this and push. Adding it here for future reference

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-02-19 at 14 08 57

@aditya-67 aditya-67 merged commit 320b5f4 into main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants