Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approving SharePoint API access permissions in admin center #9962

Open
1 of 9 tasks
AlexFilipovici opened this issue Oct 10, 2024 · 7 comments
Open
1 of 9 tasks

Approving SharePoint API access permissions in admin center #9962

AlexFilipovici opened this issue Oct 10, 2024 · 7 comments
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:rolling in production The fix has been created and it's currently rolling across all production tenants type:bug-confirmed Confirmed bug, not working as designed / expected.

Comments

@AlexFilipovici
Copy link

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

None

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

No response

Describe the bug / error

When we try to approve a SharePoint API permission in the SharePoint admin center under "Pending requests" it seems that our request has been fulfilled. At first glance the approved permission moves to the"Approved requests" group in the UI. After refreshing the page we see that the requests are not visible anymore in the "Approved requests" group.

When we inspect the network traffic, while approving, we see that the Deny endpoint is called when approving: https://tenant-admin.sharepoint.com/_api/SPOInternalUseOnly.SPOWebAppServicePrincipal/PermissionRequests('GUID')/Deny

The SPFX functionality breaks as depicted below:

image

Steps to reproduce

  1. Go to https://tenant-admin.sharepoint.com/_layouts/15/online/AdminHome.aspx#/webApiPermissionManagement
  2. Click on a pending request and approve it
  3. Notice that the request has been visually approved and moved to the "Approved requests" group
  4. Refresh the page and notice that the approved request is not visible anymore

Expected behavior

Request should be approved instead of denied when approving it.

@AlexFilipovici AlexFilipovici added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Oct 10, 2024
@VesaJuvonen VesaJuvonen added the Needs: Triage 🔍 Awaiting categorization and initial review. label Oct 30, 2024
@joelfmrodrigues
Copy link
Contributor

I am experiencing the same

@joelfmrodrigues
Copy link
Contributor

For anyone desperate for a workaround, permissions can be added directly to the Entra ID app registration that is used by SPFx. Here is a blog post covering this: https://michaelmaillot.github.io/tips/20210302-spfx-api-permissions/

@GrahamMcMynn
Copy link

Thank you for notifying us of this issue. A fix is rolling out and should reach 100% of prod on Monday December 16th. The deny is actually expected and will continue to happen. After we approve the permission (which we weren't doing and is the cause of the bug), we call the deny endpoint to remove the request from the queue.

@VesaJuvonen
Copy link
Contributor

@AlexFilipovici and @joelfmrodrigues - can you confirm that the fix is now out and things are working, like @GrahamMcMynn was sharing? - Just that we get this and #10041 closed as fix. Thx for confirming.

@VesaJuvonen VesaJuvonen added area:spfx Category: SharePoint Framework (not extensions related) type:bug-confirmed Confirmed bug, not working as designed / expected. status:rolling in production The fix has been created and it's currently rolling across all production tenants and removed type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. Needs: Triage 🔍 Awaiting categorization and initial review. labels Dec 17, 2024
@joelfmrodrigues
Copy link
Contributor

@VesaJuvonen is not working for me yet

@joelfmrodrigues
Copy link
Contributor

@GrahamMcMynn sorry to tag you here but just checking if you are also aware of a parallel discussion on this issue: #10041

Issue seems to not be resolved yet 😟

@joelfmrodrigues
Copy link
Contributor

@AlexFilipovici it just started working for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:rolling in production The fix has been created and it's currently rolling across all production tenants type:bug-confirmed Confirmed bug, not working as designed / expected.
Projects
None yet
Development

No branches or pull requests

4 participants