New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAN's main.py suspicious reshape #14

Open

ei-grad opened this issue Feb 5, 2021 · 0 comments

ei-grad commented Feb 5, 2021 •

edited

Loading

IMDB dataset is tokenized by words, so after reshape in https://github.com/ShawnyXiao/TextClassification-Keras/blob/master/model/HAN/main.py#L20-L23 word-level dimension contain the whole words tokens, not chars/wordparts. Does it make sense at all? If it is used just for illustration, then maybe it worth to add a comment near it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment