Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation on comments model #10

Open
ShehrozIrfan opened this issue Oct 7, 2022 · 3 comments
Open

Add validation on comments model #10

ShehrozIrfan opened this issue Oct 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@ShehrozIrfan
Copy link
Owner

We need to add the validations on the comments model.

  • Text is required
  • Add minimum of 10 characters limit
  • Add maximum of 500 characters limit
@ShehrozIrfan ShehrozIrfan self-assigned this Nov 6, 2022
@ShehrozIrfan ShehrozIrfan added the enhancement New feature or request label Nov 6, 2022
@ShehrozIrfan
Copy link
Owner Author

#19

@ShehrozIrfan
Copy link
Owner Author

Validation added on the comment model, as described above. And also the error messages are shown on Add Comment, Edit Comment and Reply Modal.
But there is only one UI Bug that needs to be fixed, is that the , is displayed while showing the error messages on the Reply Form Modal.
Below is the screenshot:
issue-comma-on-errors

@ShehrozIrfan ShehrozIrfan added the bug Something isn't working label Nov 12, 2022
@ShehrozIrfan ShehrozIrfan added the help wanted Extra attention is needed label Nov 20, 2022
@FaheemAhmedNoor
Copy link
Contributor

Hey! @ShehrozIrfan!
I want to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants