add admin section to the hosted app specification#6895
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success3797 tests passing in 1455 suites. Report generated by 🧪jest coverage report action from 60096cc |
JoshuaWhite1
force-pushed
the
02-25-add_admin_section_to_the_hosted_app_specification
branch
from
95b92da to
4fd1bdd
Compare
JoshuaWhite1
force-pushed
the
proj-48450/asset-pipeline-for-hosted-apps
branch
from
635fedb to
d296cb0
Compare
alfonso-noriega
changed the base branch from
proj-48450/asset-pipeline-for-hosted-apps
to
graphite-base/6895
MitchLillie
force-pushed
the
graphite-base/6895
branch
from
d296cb0 to
6b8ca49
Compare
MitchLillie
force-pushed
the
02-25-add_admin_section_to_the_hosted_app_specification
branch
from
4fd1bdd to
3f78149
Compare
MitchLillie
changed the base branch from
graphite-base/6895
to
proj-48450/asset-pipeline-for-hosted-apps
MitchLillie
force-pushed
the
02-25-add_admin_section_to_the_hosted_app_specification
branch
from
3f78149 to
60096cc
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
![binks-code-reviewer[bot]](https://avatars.githubusercontent.com/in/2788732?s=60&v=4){kind=small}
| } | ||
|
|
||
| export const HostedAppHomeSpecIdentifier = 'hosted_app_home' | ||
| export const HostedAppHomeSpecIdentifier = 'admin' |
There was a problem hiding this comment.
Identifier renamed to admin without alias/back-compat handling
The config extension spec identifier was changed from hosted_app_home to admin (export const HostedAppHomeSpecIdentifier = 'admin'). This identifier is used to match/route config modules (e.g., included in CONFIG_EXTENSION_IDS, used in spec list sorting). If existing projects/platform still send/expect hosted_app_home, the CLI may not recognize the module, may fail schema validation, or may fail to load/copy assets. This is high-risk because it can break builds/deploys for users on older config versions.
| const sourceDir = joinPath(directory, config.static_root) | ||
| const staticRoot = config.admin?.static_root | ||
| if (!staticRoot) return | ||
| const sourceDir = joinPath(directory, staticRoot) |
There was a problem hiding this comment.
Schema changed to admin.static_root without migration/fallback from legacy static_root
The schema changed from top-level static_root to a nested optional object (admin: zod.object({ static_root: zod.string().optional() }).optional()), and asset copying now reads config.admin?.static_root. Existing configs that still set static_root: "public" at the top level will result in no assets being copied (silent failure), which can break runtime behavior without obvious errors.
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 2 findings 📋 History✅ 2 findings |
1 participant
WHAT is this pull request doing?
Updates CLI for name change from hosted app -> admin
How to test your changes?
See core PR for 🎩
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist