Conversation
Coverage report
Test suite run success3790 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from fc77660 |
3573760 to
fc77660
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/conf-store.d.ts@@ -20,7 +20,7 @@ interface Cache {
}
export interface ConfSchema {
sessionStore: string;
- currentSessionId?: string;
+ currentSessionIds?: Record<string, string>;
cache?: Cache;
}
/**
@@ -40,19 +40,21 @@ export declare function setSessions(session: string, config?: LocalStorage<ConfS
*/
export declare function removeSessions(config?: LocalStorage<ConfSchema>): void;
/**
- * Get current session ID.
+ * Get current session ID for a given identity FQDN.
*
- * @returns Current session ID.
+ * @param fqdn - The identity FQDN to get the session ID for.
+ * @returns Current session ID for that environment.
*/
-export declare function getCurrentSessionId(config?: LocalStorage<ConfSchema>): string | undefined;
+export declare function getCurrentSessionId(fqdn: string, config?: LocalStorage<ConfSchema>): string | undefined;
/**
- * Set current session ID.
+ * Set current session ID for a given identity FQDN.
*
+ * @param fqdn - The identity FQDN to set the session ID for.
* @param sessionId - Session ID.
*/
-export declare function setCurrentSessionId(sessionId: string, config?: LocalStorage<ConfSchema>): void;
+export declare function setCurrentSessionId(fqdn: string, sessionId: string, config?: LocalStorage<ConfSchema>): void;
/**
- * Remove current session ID.
+ * Remove all current session IDs (across all environments).
*/
export declare function removeCurrentSessionId(config?: LocalStorage<ConfSchema>): void;
type CacheValueForKey<TKey extends keyof Cache> = NonNullable<Cache[TKey]>['value'];
|
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260303162727Caution After installing, validate the version by running |
WHY are these changes introduced?
In #5914 we added support for multiple sessions, but if you switch between environments (production/development), the sessions get overwritten, so you have to log in again.
WHAT is this pull request doing?
Stores sessions grouped per environment, so they can be re-used when switching between them.
How to test your changes?
npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260303162727shopify auth logoutshopify app versions listSHOPIFY_SERVICE_ENV=local shopify app versions listshopify app versions listSHOPIFY_SERVICE_ENV=local shopify app versions listIt should only start the login flow once per environment.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist