Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AA] Add toddler sizes to Size attribute #274

Closed
wants to merge 2 commits into from
Closed

[AA] Add toddler sizes to Size attribute #274

wants to merge 2 commits into from

Conversation

KComrade53
Copy link
Contributor

Adds age-range toddler sizes to the Size attribute

@KComrade53 KComrade53 mentioned this pull request Aug 13, 2024
Merged
tylerrowsell
tylerrowsell reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@tylerrowsell tylerrowsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense... we are figuring out the translations piece going forward so may need to hold until that lands.

@elsom25
Copy link
Collaborator

elsom25 commented Aug 13, 2024

I do love how generally simple the bin command is in the other PR to generate these changes. System is starting to show its merits 🎉

ricardotejedorsanz
ricardotejedorsanz approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@ricardotejedorsanz ricardotejedorsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree Size is the right attribute for these changes. I suggest we add a few more missing values in the Baby/Toddler size range.

@ricardotejedorsanz ricardotejedorsanz added the taxonomy-tree-requests Suggestion to improve to the taxonomy tree label Oct 3, 2024
@ricardotejedorsanz ricardotejedorsanz changed the title Add toddler sizes to Size attribute [AA] Add toddler sizes to Size attribute Oct 5, 2024
@ricardotejedorsanz ricardotejedorsanz self-assigned this Oct 6, 2024
@ricardotejedorsanz ricardotejedorsanz changed the base branch from main to patch-1 October 7, 2024 19:35
@ricardotejedorsanz ricardotejedorsanz marked this pull request as ready for review October 7, 2024 19:50
@ricardotejedorsanz ricardotejedorsanz changed the base branch from patch-1 to main October 8, 2024 12:05
@ricardotejedorsanz
Copy link
Contributor

I have signed the CLA!

@ricardotejedorsanz ricardotejedorsanz mentioned this pull request Oct 8, 2024
Merged
@ricardotejedorsanz
Copy link
Contributor

Moving to #390 to override CLA issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerrowsell tylerrowsell tylerrowsell approved these changes

@ricardotejedorsanz ricardotejedorsanz ricardotejedorsanz approved these changes

@ChahnaGupta ChahnaGupta Awaiting requested review from ChahnaGupta

Assignees

@ricardotejedorsanz ricardotejedorsanz

Labels
2024-10 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KComrade53 @elsom25 @ricardotejedorsanz @tylerrowsell