Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AE] Add category for Clothing Sewing Materials #366

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

ricardotejedorsanz
Copy link
Contributor

It has been flagged [issues/3443] that our current taxonomy lacks a dedicated category specifically for clothing sewing materials. This gap could potentially affect merchants who need to apply state-specific tax exemptions for items like fabric, thread, buttons, and zippers used in clothing construction, as required by New Jersey and Minnesota laws.

Existing categories under Arts & Entertainment > Hobbies & Creative Arts > Arts & Crafts can be a suitable umbrella for these products, but they do not clearly distinguish between general crafting materials and those intended for clothing (see image below). We propose creating a new category: Arts & Entertainment > Hobbies & Creative Arts > Arts & Crafts > Clothing Sewing Materials. This should more accurately denote clothing sewing-related materials and could be expanded in the future as needed or serve as a parent to applicable subcategories such as Craft Fasteners & Closures, Crafting Fibers, or Textiles.

image
image

@ricardotejedorsanz ricardotejedorsanz added the taxonomy-tree-requests Suggestion to improve to the taxonomy tree label Oct 4, 2024
@ricardotejedorsanz ricardotejedorsanz self-assigned this Oct 4, 2024
@ricardotejedorsanz
Copy link
Contributor Author

Copy link
Member

@tylerrowsell tylerrowsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a technical side of things.

I trust your judgement here, but generally we should be careful adding things simply because it doesn't fit into a tax category. We don't want our taxonomy system to be become overcomplicated with exceptions.

In this case it seems like it can fit though.

@ricardotejedorsanz
Copy link
Contributor Author

I trust your judgement here, but generally we should be careful adding things simply because it doesn't fit into a tax category. We don't want our taxonomy system to be become overcomplicated with exceptions.

@tyler Yes, I completely agree. These should be exceptions rather than the rule, as it's unlikely we can account for all the different tax groupings across every jurisdiction with a single taxonomy tree.

That's why I wouldn't create further duplication by expanding the available leaves under these categories. A single category can still serve as a valid solution without creating excessive overlaps.

@ricardotejedorsanz ricardotejedorsanz merged commit 7e92e7e into main Oct 6, 2024
5 checks passed
@ricardotejedorsanz ricardotejedorsanz deleted the ae-clothing-fabrics branch October 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-10 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants