Add name location to classes and modules

[vinistock]

There's one thing missing from class and module indexing to match the LSP: their name location (as opposed to the entire definition's location).

This is necessary because of the way the LSP spec works in this case (example taken from our own code):

class Entry
  class Method < Entry # go to def here
  end
end

Because the parent class Entry constant reference is fully inside the class Entry's location, the editor fires a find references request instead of a go to definition one. This is incorrect since Entry is a reference.

The spec's way of fixing this is allowing servers to return both a name and selection locations, which is what we need to start indexing. The name location is simply the location of the module/class constant_path.

[Morriar]

Let's also update the diagnostics to point to the name location instead of the declaration location.

[st0012]

Let's also update the diagnostics to point to the name location instead of the declaration location.

Do we have such cases right now? I don't see it by searching add_diagnostic.

[Morriar]

Let's also update the diagnostics to point to the name location instead of the declaration location.

Do we have such cases right now? I don't see it by searching add_diagnostic.

I believe it's in #474, merge I'll update 👍

[st0012]

@Morriar merged!

[Morriar]

Reopening the time I get this updated