Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing --with-openssl-dir for a custom OpenSSL installation #499

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Allow passing --with-openssl-dir for a custom OpenSSL installation #499

merged 1 commit into from
Jul 31, 2023

Conversation

kalbasit
Copy link
Contributor

@kalbasit kalbasit commented Jul 7, 2023

OpenSSL isn't located on standard paths on my Linux machine and thus I can't get Semian gem to install.

Before the flag

❯ ruby ext/semian/extconf.rb
checking for openssl/sha.h... no
openssl is missing. please install openssl.
*** ext/semian/extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
        --with-opt-dir
        --without-opt-dir
        --with-opt-include
        --without-opt-include=${opt-dir}/include
        --with-opt-lib
        --without-opt-lib=${opt-dir}/lib
        --with-make-prog
        --without-make-prog
        --srcdir=ext/semian
        --curdir
        --ruby=/nix/store/3ay21xsh45kjqfpsan7xmnf3mbng29d7-ruby-3.0.2/bin/$(RUBY_BASE_NAME)

After the flag

❯ ruby ext/semian/extconf.rb --with-openssl-dir=$(readlink -f result)
checking for openssl/sha.h... yes
checking for SHA1() in -lcrypto... yes
checking for sys/ipc.h... yes
checking for sys/sem.h... yes
checking for sys/types.h... yes
checking for rb_thread_blocking_region()... no
checking for rb_thread_call_without_gvl()... yes
creating Makefile

@kalbasit
Copy link
Contributor Author

kalbasit commented Jul 7, 2023

I have signed the CLA!

@kalbasit
Copy link
Contributor Author

@casperisfine mind review the pr?

@casperisfine casperisfine merged commit 02feadc into Shopify:master Jul 31, 2023
39 of 41 checks passed
@casperisfine
Copy link
Contributor

Thanks

@kalbasit kalbasit deleted the keeptruckin/DEVPRD-1195/semian-gem branch August 5, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants