Loosen Guzzlehttp requirement to allow v6

[MagicLegend]

Overview/summary

I'd like to see the requirement for guzzle/guzzlehttp loosened to also allow v6, instead of ^7.0. I have forked the project, and downgraded the package. All tests still succeed, so I'm assuming v6 is fully compatible with this package as well.

I also have loosened doctrine/inflector to allow v1, which also doesn't break the tests. This is a deeper dependency to two Magento packages as well.

Motivation

Magento v2.4.3 uses Guzzlehttp v6, and upgrading Magento is simply not an option. In our case:

$ composer2 why guzzlehttp/guzzle
magento/ece-tools                                  2002.1.10   requires  guzzlehttp/guzzle (^6.3||^7.3)
magento/framework                                  103.0.3-p1  requires  guzzlehttp/guzzle (^6.3.3)
magento/module-catalog-sync-admin                  1.0.4       requires  guzzlehttp/guzzle (~6.0)
magento/module-product-recommendations-admin       3.0.4       requires  guzzlehttp/guzzle (~6.0)
magento/module-product-recommendations-sync-admin  1.0.1       requires  guzzlehttp/guzzle (~6.0)
magento/product-community-edition                  2.4.3-p1    requires  guzzlehttp/guzzle (^6.3.3)                                                                                                                                                        
magento/product-enterprise-edition                 2.4.3-p1    requires  guzzlehttp/guzzle (^6.3.3)        
magento/product-recommendations-admin              3.0.5       requires  guzzlehttp/guzzle (~6.0)
magento/services-connector                         1.2.0       requires  guzzlehttp/guzzle (6.*)

$ composer2 why doctrine/inflector
illuminate/support  v5.8.36  requires  doctrine/inflector (^1.1)

$ composer2 why illuminate/support
illuminate/config  v5.8.36  requires  illuminate/support (5.8.*)  

$ composer2 why illuminate/config
magento/ece-tools             2002.1.10  requires  illuminate/config (^5.5||^8.77)
magento/magento-cloud-docker  1.3.2      requires  illuminate/config (^5.5||^8.77)

Would be great if it'd be allowed to use both packages with a lower version for better compatability.

[MagicLegend]

For those in the future; I have created a fork that supports the lower versions of both inflector and Guzzle. The changes should be compatible with Guzzle v7 as well (although at the time untested since I don't need them). Perhaps one day this compatibility can be introduced in the main package as well?

[github-actions]

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Still waiting on Shopify...

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Still waiting on Shopify...

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Still waiting on Shopify...

[rafaelstz]

Hey @MagicLegend, you were referring to Magento in your issue description, is it placed in the right place?

[MagicLegend]

Hey @rafaelstz, yes I'm in the right place. I'm referring to the guzzlehttp requirement that this package has:

shopify-api-php/composer.json

Line 40 in 7a5b651

"guzzlehttp/guzzle": "^7.0",

Since it does not allow v6, it restricts compatability with Magento versions <2.4.4, as per the change in guzzlehttp requirement between v2.4.3 and v2.4.4: magento/magento2@3083779. I'm referring to Magento to show that this package is not compatible with <2.4.4 for this reason. Reading it again I do understand where you're coming from though, I hope I've cleared it up.

Also see my fork of this package in which I fixed a bunch of issues, including this one: https://github.com/MagicLegend/shopify-php-api

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[MagicLegend]

Yeah, and why is it stale bot? Because Shopify doesn't reply ;)

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[ZacharyDuBois]

Still waiting for Shopify to reply...

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[ZacharyDuBois]

Issue wouldn't be stale if Shopify would answer

[MagicLegend]

Happy 2 years without a reply from Shopify! 🎉

[ZacharyDuBois]

[fulldecent]

Recommending to close this issue.

Guzzle 6.x is now end-of-life. Source: https://github.com/guzzle/guzzle?tab=readme-ov-file#version-guidance

This Shopify repo is currently supported at the "please send PRs" level. Source: #322 (comment)

Therefore, I think it is reasonable to understand the project's scope as not including depending on unsupported dependencies.

[MagicLegend]

Hi @fulldecent ,

Well, when I opened the ticket Magento 2.4.3 was already almost EOL. But just because something is EOL doesn't mean nobody uses it anymore :-)

This Shopify repo is currently supported at the "please send PRs" level. Source: #322 (comment)

My fork has been in production use since I opened this ticket, but I assume it will need some more cleanup before Shopify would accept it. But without any input from their side, I don't know what they'd exactly want changed.

Therefore, I think it is reasonable to understand the project's scope as not including depending on unsupported dependencies.

Well if you read my changes you'll see that all I did was allow ^6.3 together with ^7, since this resolved the conflict I had. So no full downgrade happened, and if your projects dependencies allow it it will prefer version 7.

---

Anyhow, the only reason we're here is because Shopify hasn't replied in over 2 years :-) I guess it took them that long to admit that they practically abandoned the package, as per the comment you quoted from #322 . Given that the changes in my fork are there for anyone who lands on this issue because they had the same problem I did, I'm fine with closing this issue.