Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Theme check - Disable checks using Liquid comments next-line #788

Open
madsenmm opened this issue Feb 13, 2025 · 0 comments · May be fixed by #796
Open

[Feature] Theme check - Disable checks using Liquid comments next-line #788

madsenmm opened this issue Feb 13, 2025 · 0 comments · May be fixed by #796
Assignees
Labels
enhancement New feature or request

Comments

@madsenmm
Copy link
Contributor

madsenmm commented Feb 13, 2025

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Would be nice to expand this check to work as eslint, with the option to only disable check for next-line.
Prevents the need to enable check after the code block again.

Current:

{%- liquid
  # theme-check-disable UnknownFilter
  assign has_layout = ids | has: 'layout'
  # theme-check-enable UnknownFilter
-%}

Feature request

{%- liquid
  # theme-check-disable-next-line UnknownFilter
  assign has_layout = ids | has: 'layout'
-%}

Additional context
https://shopify.dev/docs/storefronts/themes/tools/theme-check/configuration#disable-checks-using-liquid-comments

@graygilmore graygilmore self-assigned this Feb 15, 2025
@graygilmore graygilmore linked a pull request Feb 15, 2025 that will close this issue
3 tasks
@graygilmore graygilmore added the enhancement New feature or request label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants