Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiquidDoc] Support param type validations when value is a variable #818

Open
jamesmengo opened this issue Feb 25, 2025 · 0 comments
Open
Labels
#gsd:44310 LiquidDoc

Comments

@jamesmengo
Copy link
Contributor

I feel like it can be done. Not sure if there is a clean way but want to capture it in a ticket.

E.g. If you visit the AssignMarkup, you can see what type it is under node.value.expression.type. But i do this this fails pretty quickly for complex assigns:

{% assign foo = product.handle | filter1 | filter 2 %}

We have a symbols table in TypeSystem (packages/theme-language-server-common), but we'd have to move it over. We can investigate this after though.

Originally posted by @aswamy in #792 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Development

No branches or pull requests

1 participant