Rename doc param or its usage #811
Merged
+197
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmengo
reviewed
Feb 26, 2025
jamesmengo
reviewed
Feb 26, 2025
packages/theme-language-server-common/src/rename/providers/LiquidVariableRenameProvider.spec.ts
Show resolved
Hide resolved
jamesmengo
reviewed
Feb 26, 2025
Comment on lines
104
to
108
| (!!parentNode && | ||
| parentNode.type === NodeTypes.LiquidDocParamNode && | ||
| // We can only rename param tag's name; not its type or description | ||
| parentNode.paramName === node && | ||
| node.type === NodeTypes.TextNode) |
There was a problem hiding this comment.
For clarity purposes, I feel like this should be in a variable or its own function. WDYT?
There was a problem hiding this comment.
I've received this comment a couple times, but can you clarify what you mean by this?
It's already in a pretty concise function. Do you want me to separate this into another one?
There was a problem hiding this comment.
It's more of a personal preference, so I won't be hurt if you choose to go in a different direction!
I think separating this into another function or a variable such as const isLiquidDocParamNameNode would make it easier to reason about as someone not familiar with this code.
That would also allow us to only read from ancestors when needed.
jamesmengo
approved these changes
Feb 26, 2025
aswamy
force-pushed
the
rename-liquid-doc-param-var
branch
from
5f63055 to
fbf6b17
Compare
aswamy
force-pushed
the
rename-liquid-doc-param-var
branch
from
fbf6b17 to
afebc66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Closes #810
NOTE: if you have a
assign(or equivalent) that collides with theparamtag in doc, assume they are referring to the same variable and rename everything.Tophat
echotag, etc.)Before you deploy
changeset