Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Unused const in pylandau_src.cpp ? #22

Open
leloup314 opened this issue Apr 25, 2022 · 1 comment
Open

Question: Unused const in pylandau_src.cpp ? #22

leloup314 opened this issue Apr 25, 2022 · 1 comment
Labels
question

Comments

@leloup314
Copy link
Member

The const double norm in pylandau_src.cpp is unsused, as far as I can see. Is this a bug and should something be normalized here?
@cbespin
Copy link
Collaborator

cbespin commented Apr 25, 2022

Good catch, thanks! I will look into it, I have no experience with discrete convolutions (yet) and did not write that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbespin @leloup314