Merge pull request #558 from SiaFoundation/nate/fix-price-pinning

Fix price pinning

Author: n8maninger

.changeset/fixed_an_issue_with_price_pinning_not_updating_prices.md

@@ -0,0 +1,5 @@
+---
+default: patch
+---
+
+# Fixed an issue with price pinning not updating prices

cmd/hostd/run.go

@@ -421,6 +421,7 @@ func runRootCmd(ctx context.Context, cfg config.Config, walletKey types.PrivateK
 		if err != nil {
 			return fmt.Errorf("failed to create pin manager: %w", err)
 		}
+		defer pm.Close()
 
 		apiOpts = append(apiOpts, api.WithPinnedSettings(pm), api.WithExplorer(ex))
 	}

host/settings/pin/pin.go

@@ -11,6 +11,7 @@ import (
 	"go.sia.tech/core/types"
 	"go.sia.tech/hostd/alerts"
 	"go.sia.tech/hostd/host/settings"
+	"go.sia.tech/hostd/internal/threadgroup"
 	"go.uber.org/zap"
 	"lukechampine.com/frand"
 )
@@ -80,6 +81,7 @@ type (
 		alerts Alerts
 		forex  Forex
 		sm     SettingsManager
+		tg     *threadgroup.ThreadGroup
 
 		frequency  time.Duration
 		rateWindow time.Duration
@@ -252,8 +254,20 @@ func (m *Manager) Update(ctx context.Context, p PinnedSettings) error {
 	return nil
 }
 
-// Run starts the PinManager's update loop.
-func (m *Manager) Run(ctx context.Context) error {
+// Close closes the PinManager.
+func (m *Manager) Close() error {
+	m.tg.Stop()
+	return nil
+}
+
+// run starts the PinManager's update loop.
+func (m *Manager) run() error {
+	ctx, cancel, err := m.tg.AddContext(context.Background())
+	if err != nil {
+		return err
+	}
+	defer cancel()
+
 	t := time.NewTicker(m.frequency)
 
 	// update prices immediately
@@ -300,6 +314,7 @@ func NewManager(store Store, settings SettingsManager, f Forex, opts ...Option)
 		sm:    settings,
 		forex: f,
 
+		tg:     threadgroup.New(),
 		alerts: alerts.NewNop(),
 		log:    zap.NewNop(),
 
@@ -325,5 +340,7 @@ func NewManager(store Store, settings SettingsManager, f Forex, opts ...Option)
 		return nil, fmt.Errorf("failed to get pinned settings: %w", err)
 	}
 	m.settings = pinned
+
+	go m.run() // run the update loop in the background
 	return m, nil
 }

host/settings/pin/pin_test.go

@@ -131,6 +131,7 @@ func TestPinnedFields(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
+	defer pm.Close()
 
 	initialSettings := sm.Settings()
 	pin := pin.PinnedSettings{
@@ -230,19 +231,7 @@ func TestAutomaticUpdate(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if err != nil {
-		t.Fatal(err)
-	}
-	ctx, cancel := context.WithCancel(context.Background())
-	defer cancel()
-	go func() {
-		if err := pm.Run(ctx); err != nil {
-			if errors.Is(err, context.Canceled) {
-				return
-			}
-			panic(err)
-		}
-	}()
+	defer pm.Close()
 
 	time.Sleep(time.Second)