fix(renterd,hostd): contract showing empty renewed from to IDs

Author: alexfreska

.changeset/fresh-actors-deny.md

@@ -0,0 +1,5 @@
+---
+'hostd': patch
+---
+
+Contracts that have not been renewed from or two another contract no longer show the empty contract ID in the contract ID table cell. Closes https://github.com/SiaFoundation/hostd/issues/524

.changeset/fresh-mice-sneeze.md

@@ -0,0 +1,5 @@
+---
+'renterd': patch
+---
+
+Contracts that have not been renewed from another contract no longer show the empty contract ID in the contract ID table cell.

apps/hostd-e2e/src/specs/contracts.spec.ts

@@ -1,7 +1,7 @@
 import { test, expect } from '@playwright/test'
 import { navigateToContracts } from '../fixtures/navigate'
 import { afterTest, beforeTest } from '../fixtures/beforeTest'
-import { getContractRowsAll } from '../fixtures/contracts'
+import { getContractRows, getContractRowsAll } from '../fixtures/contracts'
 
 test.beforeEach(async ({ page }) => {
   await beforeTest(page, {
@@ -27,3 +27,11 @@ test('contracts bulk integrity check', async ({ page }) => {
     page.getByText('Integrity checks started for 2 contracts')
   ).toBeVisible()
 })
+
+test('new contracts do not show a renewed from or to contract', async ({
+  page,
+}) => {
+  await navigateToContracts(page)
+  await expect(getContractRows(page).getByTestId('renewedFrom')).toBeHidden()
+  await expect(getContractRows(page).getByTestId('renewedTo')).toBeHidden()
+})

apps/hostd/contexts/contracts/columns.tsx

@@ -79,6 +79,7 @@ export const columns: ContractsTableColumn[] = (
                     <ArrowUpLeft16 className="scale-75" />
                   </Text>
                   <ValueCopyable
+                    testId="renewedFrom"
                     color="subtle"
                     size="10"
                     type="contract"
@@ -95,6 +96,7 @@ export const columns: ContractsTableColumn[] = (
                     <ArrowDownRight16 className="scale-75" />
                   </Text>
                   <ValueCopyable
+                    testId="renewedTo"
                     color="subtle"
                     size="10"
                     value={stripPrefix(renewedTo)}

apps/hostd/contexts/contracts/dataset.ts

@@ -91,9 +91,9 @@ function getContractFields(c: Contract): ContractData {
     renewedFrom: c.renewedFrom,
     isRenewedFrom:
       c.renewedFrom !==
-      'fcid:0000000000000000000000000000000000000000000000000000000000000000',
+      '0000000000000000000000000000000000000000000000000000000000000000',
     isRenewedTo:
       c.renewedTo !==
-      'fcid:0000000000000000000000000000000000000000000000000000000000000000',
+      '0000000000000000000000000000000000000000000000000000000000000000',
   }
 }

apps/renterd-e2e/src/specs/contracts.spec.ts

@@ -4,6 +4,7 @@ import { navigateToContracts } from '../fixtures/navigate'
 import { afterTest, beforeTest } from '../fixtures/beforeTest'
 import {
   getContractRowByIndex,
+  getContractRows,
   getContractRowsAll,
   getContractsSummaryRow,
 } from '../fixtures/contracts'
@@ -145,3 +146,8 @@ test('contracts bulk blocklist', async ({ page }) => {
   await dialog.getByLabel('view allowlist').click()
   await expect(dialog.getByText('The allowlist is empty')).toBeVisible()
 })
+
+test('new contracts do not show a renewed from', async ({ page }) => {
+  await navigateToContracts({ page })
+  await expect(getContractRows(page).getByTestId('renewedFrom')).toBeHidden()
+})

apps/renterd/contexts/contracts/columns.tsx

@@ -77,6 +77,7 @@ export const columns: ContractsTableColumn[] = [
                   <ArrowUpLeft16 className="scale-75" />
                 </Text>
                 <ValueCopyable
+                  testId="renewedFrom"
                   color="subtle"
                   size="10"
                   type="contract"

apps/renterd/contexts/contracts/dataset.tsx

@@ -35,7 +35,7 @@ export function useDataset() {
       response.data?.map((c) => {
         const isRenewed =
           c.renewedFrom !==
-          'fcid:0000000000000000000000000000000000000000000000000000000000000000'
+          '0000000000000000000000000000000000000000000000000000000000000000'
         const startTime = blockHeightToTime(currentHeight, c.startHeight)
         const endHeight = c.windowStart
         const endTime = blockHeightToTime(currentHeight, endHeight)