Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cache] Make use of the new pkg/cache package and for all the caching layers in query service #6797

Open
shivanshuraj1333 opened this issue Jan 10, 2025 · 0 comments
Assignees

Comments

@shivanshuraj1333
Copy link
Member

We recently introduced a new cache package in #6733 that supports having CacheableEntity and the whole object can be stored in the Cache.

Previously only Marshaled data was being stored https://github.com/SigNoz/signoz/blob/main/pkg/query-service/cache/inmemory/cache.go#L29

We can now deprecate old cache implementation residing in https://github.com/SigNoz/signoz/blob/main/pkg/query-service/cache/inmemory/cache.go, and can completely use the new Cache package https://github.com/SigNoz/signoz/tree/main/pkg/cache for Redis and in-memory cache.

@shivanshuraj1333 shivanshuraj1333 self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant