fix: disabled same url check for redirect in logs explorer

[sawhil]

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Adds option to disable same URL check in useSafeNavigate and applies it to LOGS data source in QueryBuilderProvider.

• Behavior:
  • Adds enableSameURLCheck option to useSafeNavigate in useSafeNavigate.ts to control same URL navigation check.
  • In QueryBuilder.tsx, disables same URL check for LOGS data source by passing enableSameURLCheck: false to useSafeNavigate.
• Functions:
  • Modifies useSafeNavigate to accept UseSafeNavigateProps with enableSameURLCheck defaulting to true.
  • Updates safeNavigate function to respect enableSameURLCheck flag.
• Misc:
  • Updates dependencies in useSafeNavigate hook to include enableSameURLCheck.

^{This description was created by for 84c61f8. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 84c61f8 in 1 minute and 14 seconds

More details

• Looked at 59 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. frontend/src/hooks/useSafeNavigate.ts:86

• Draft comment:
  Nice work adding an option to disable the same URL check. Ensure that tests cover both enabled and disabled scenarios.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50%
  None

2. frontend/src/hooks/useSafeNavigate.ts:117

• Draft comment:
  Good conditional check based on enableSameURLCheck. Double-check if other parts of URL comparison need similar flexibility.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50%
  None

3. frontend/src/providers/QueryBuilder.tsx:766

• Draft comment:
  Passing enableSameURLCheck as a function of the data source is a clear solution for logs explorer redirection.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50%
  None

4. frontend/src/hooks/useSafeNavigate.ts:86

• Draft comment:
  Good implementation: the new enableSameURLCheck parameter defaults to true and is correctly used in the safeNavigate callback. The dependency array now includes enableSameURLCheck, ensuring that its changes are respected. Consider adding a brief comment or JSDoc note explaining its usage.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

5. frontend/src/providers/QueryBuilder.tsx:766

• Draft comment:
  The safeNavigate hook is now invoked with enableSameURLCheck disabled when initialDataSource equals DataSource.LOGS, which fits the logs explorer fix. Make sure that initialDataSource updates appropriately to reflect the logs data source when needed.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

6. frontend/src/providers/QueryBuilder.tsx:169

• Draft comment:
  Typo: The variable name 'setupedQueryData' is misspelled. Consider renaming it to 'setupQueryData' or 'preparedQueryData' for improved clarity.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_lB64EAMdqKRhLnC0

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[SagarRajput-7]

Have we checked the same on traces page? Why only logs here.

[sawhil]

For now, just did for logs. After Shaheer shares his reasoning for the same change. Will either remove the whole check or add the flag from required sources.

[ahmadshaheer]

@sawhil ,

in the areUrlsEffectivelySame function, we are checking if the urls are effectively the same i.e. if the composite query and other params are the same. if so, we prevent the navigation. (#6701)

I think we need to add the enableSameURLCheck flag for traces as well.

[ahmadshaheer]

can we slightly change this to make it more readable?

e.g.

we can change this to

	{ preventSameUrlNavigation }: UseSafeNavigateProps = { preventSameUrlNavigation: true },

if we want to enable same url navigation in the consumers. we could say

	const { safeNavigate } = useSafeNavigate({
		preventSameUrlNavigation: false,
	});