Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

/signalk returning weird version output #40

Closed
ph1l opened this issue Mar 30, 2017 · 2 comments
Closed

/signalk returning weird version output #40

ph1l opened this issue Mar 30, 2017 · 2 comments

Comments

@ph1l
Copy link
Contributor

ph1l commented Mar 30, 2017

Looks like there is a bug in the endpoints data. (http://signalk.org/specification/master/urls_etc.html#versioning)

elektron@x61s:~/code/python-signalk-client$ curl -s http://localhost:8080/signalk | jq .
{
  "endpoints": {
    "1.": {
      "signalk-tcp": "tcp://localhost:55555",
      "signalk-udp": "udp://localhost:55554",
      "nmea-tcp": "tcp://localhost:55557",
      "nmea-udp": "udp://localhost:55556",
      "signalk-http": "http://localhost:8080/signalk/v1/api/",
      "mqtt": "mqtt://localhost:1883",
      "signalk-ws": "ws://localhost:3000/signalk/v1/stream",
      "stomp": "stomp+nio://localhost:61613",
      "version": ".0.0"
    }
  }
}
  • endpoints.v1 should exist, but doesn't.
  • endpoints.v1.version of .0.0 doesn't make sense
@rob42
Copy link
Contributor

rob42 commented Apr 3, 2017

Its an artifact of the old version number, which included the 'v', eg v1.0.0.
The code truncates the the wrong bits now. Fixing

@rob42
Copy link
Contributor

rob42 commented Apr 3, 2017

Fixed in JIT-Deploy-34

@rob42 rob42 closed this as completed Apr 3, 2017
rob42 added a commit that referenced this issue Apr 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants