Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list-all-secrets orders domain letters instead of domains #14

Open
graffic opened this issue Apr 14, 2020 · 2 comments
Open

list-all-secrets orders domain letters instead of domains #14

graffic opened this issue Apr 14, 2020 · 2 comments

Comments

@graffic
Copy link

graffic commented Apr 14, 2020

When a secret is only in one or more domains, the output is always the domain letters sorted. Example with the staging environment

$ pprotect list-all-secrets
MY_PASSWORD: a, g, i, n, s, t
  • Python 3.8.2
  • pocket_protector: git version on master.
tipabu added a commit to tipabu/pocket_protector that referenced this issue Apr 15, 2020
@mahmoud
Copy link
Contributor

mahmoud commented Apr 15, 2020

Good report, and good catch. I'd ask for a PR or to fix it myself, but it's already fixed in master! I'd suggest pip installing from the repo and trying it out, but I'm fairly confident in the fix. Will post back here when a new version is published (soon, within the next week, latest).

@graffic
Copy link
Author

graffic commented Apr 23, 2020

Thank you very much @mahmoud and thank you for the fix :)

No worries about the new version, I usually install from the git repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants