[3.0] Confusing notification settings

[LiroyvH]

Not entirely sure if it should be categorised as bug, more like a potential for enhancement.

In the notifications settings, you cannot enable/disable "notifications" for Personal Messages. You can only enable/disable getting an e-mail. However, you can get pop-ups from SMF saying you have new messages.

I think this may be confusing, because the setting to control that is not under notification settings, but is in the lay-out section. ("Show a pop-up when I receive new messages"). Imho, this isn't a lay-out setting but should probably go to the notifications to prevent confusion/people looking in the wrong place; despite this pop-up not technically being a notification for the feature that is controlled in that window. (On the other hand it could be argued it isn't relevant to the lay-out either, so doesn't really make a difference where it is in the partially right/wrong location... :P)

To be honest, it would make more sense to me to actually allow users to get notifications for Personal Messages instead of e-mail only, and then remove the pop-up feature. But that's perhaps a bit late now. :)

[Sesquipedalian]

Imho, this isn't a lay-out setting but should probably go to the notifications to prevent confusion/people looking in the wrong place; despite this pop-up not technically being a notification for the feature that is controlled in that window.

You're not wrong.

[jdarwood007]

Tagging this for 3.0 after the installer/upgrader overhaul finishes. It should be fairly easy to do this.

We will get rid of the setting completely under look and layout, then allow toggling the notification option for PMs (which we currently can't do). We then, in the upgrade, migrate the option over. There are two options, new and replies, for PMs, but I don't see an issue with the upgrade just populating both with the same value.

[Sesquipedalian]

There are two options, new and replies, for PMs

We probably can and should amalgamate that into a single setting while we're at it. It's hard to imagine a scenario where I would want to be notified about new PMs but not about replies.

If we do want to give people more granular control of which PMs they are notified about, we would do better to allow users to turn notifications on or off for certain conversations rather than for different message types.

Also, I would definitely classify this as a feature enhancement, not a bug.