tech debt

Author: AnkushMalaker

backends/advanced/src/advanced_omi_backend/app_config.py

@@ -13,9 +13,13 @@
 from dotenv import load_dotenv
 from motor.motor_asyncio import AsyncIOMotorClient
 
-from advanced_omi_backend.constants import OMI_CHANNELS, OMI_SAMPLE_RATE, OMI_SAMPLE_WIDTH
-from advanced_omi_backend.services.transcription import get_transcription_provider
+from advanced_omi_backend.constants import (
+    OMI_CHANNELS,
+    OMI_SAMPLE_RATE,
+    OMI_SAMPLE_WIDTH,
+)
 from advanced_omi_backend.model_registry import get_models_registry
+from advanced_omi_backend.services.transcription import get_transcription_provider
 
 # Load environment variables
 load_dotenv()

backends/advanced/src/advanced_omi_backend/app_factory.py

@@ -23,20 +23,25 @@
     fastapi_users,
     websocket_auth,
 )
+from advanced_omi_backend.client_manager import get_client_manager
+from advanced_omi_backend.middleware.app_middleware import setup_middleware
+from advanced_omi_backend.routers.api_router import router as api_router
+from advanced_omi_backend.routers.modules.health_routes import router as health_router
+from advanced_omi_backend.routers.modules.websocket_routes import (
+    router as websocket_router,
+)
+from advanced_omi_backend.services.audio_service import get_audio_stream_service
+from advanced_omi_backend.services.memory import (
+    get_memory_service,
+    shutdown_memory_service,
+)
+from advanced_omi_backend.task_manager import get_task_manager, init_task_manager
 from advanced_omi_backend.users import (
     User,
     UserRead,
     UserUpdate,
     register_client_to_user,
 )
-from advanced_omi_backend.client_manager import get_client_manager
-from advanced_omi_backend.services.memory import get_memory_service, shutdown_memory_service
-from advanced_omi_backend.middleware.app_middleware import setup_middleware
-from advanced_omi_backend.routers.api_router import router as api_router
-from advanced_omi_backend.routers.modules.health_routes import router as health_router
-from advanced_omi_backend.routers.modules.websocket_routes import router as websocket_router
-from advanced_omi_backend.services.audio_service import get_audio_stream_service
-from advanced_omi_backend.task_manager import init_task_manager, get_task_manager
 
 logger = logging.getLogger(__name__)
 application_logger = logging.getLogger("audio_processing")
@@ -51,7 +56,10 @@ async def initialize_openmemory_user() -> None:
     - Creates a test memory and deletes it to trigger user creation
     - Logs success or warning if OpenMemory is not reachable
     """
-    from advanced_omi_backend.services.memory.config import build_memory_config_from_env, MemoryProvider
+    from advanced_omi_backend.services.memory.config import (
+        MemoryProvider,
+        build_memory_config_from_env,
+    )
 
     memory_provider_config = build_memory_config_from_env()
 
@@ -99,11 +107,12 @@ async def lifespan(app: FastAPI):
     # Initialize Beanie for all document models
     try:
         from beanie import init_beanie
-        from advanced_omi_backend.models.conversation import Conversation
+
+        from advanced_omi_backend.models.annotation import Annotation
         from advanced_omi_backend.models.audio_chunk import AudioChunkDocument
+        from advanced_omi_backend.models.conversation import Conversation
         from advanced_omi_backend.models.user import User
         from advanced_omi_backend.models.waveform import WaveformData
-        from advanced_omi_backend.models.annotation import Annotation
 
         await init_beanie(
             database=config.db,
@@ -139,6 +148,27 @@ async def lifespan(app: FastAPI):
         application_logger.error(f"Failed to connect to Redis for RQ: {e}")
         application_logger.warning("RQ queue system will not be available - check Redis connection")
 
+    # Initialize BackgroundTaskManager (must happen before any code path uses it)
+    try:
+        task_manager = init_task_manager()
+        await task_manager.start()
+        application_logger.info("BackgroundTaskManager initialized and started")
+    except Exception as e:
+        application_logger.error(f"Failed to initialize task manager: {e}")
+        raise  # Task manager is essential
+
+    # Initialize ClientManager eagerly (prevents lazy race on first WebSocket connect)
+    get_client_manager()
+    application_logger.info("ClientManager initialized")
+
+    # Initialize LLM client eagerly (catch config errors at startup, not on first request)
+    try:
+        from advanced_omi_backend.llm_client import get_llm_client
+        get_llm_client()
+        application_logger.info("LLM client initialized from config.yml")
+    except Exception as e:
+        application_logger.warning(f"LLM client initialization deferred: {e}")
+
     # Initialize audio stream service for Redis Streams
     try:
         audio_service = get_audio_stream_service()
@@ -161,7 +191,9 @@ async def lifespan(app: FastAPI):
         application_logger.info("✅ Redis client for audio streaming producer initialized")
 
         # Initialize ClientManager Redis for cross-container client→user mapping
-        from advanced_omi_backend.client_manager import initialize_redis_for_client_manager
+        from advanced_omi_backend.client_manager import (
+            initialize_redis_for_client_manager,
+        )
         initialize_redis_for_client_manager(config.redis_url)
 
     except Exception as e:
@@ -180,7 +212,10 @@ async def lifespan(app: FastAPI):
 
     # Initialize plugins using plugin service
     try:
-        from advanced_omi_backend.services.plugin_service import init_plugin_router, set_plugin_router
+        from advanced_omi_backend.services.plugin_service import (
+            init_plugin_router,
+            set_plugin_router,
+        )
 
         plugin_router = init_plugin_router()
 
@@ -221,11 +256,23 @@ async def lifespan(app: FastAPI):
         client_manager = get_client_manager()
         for client_id in client_manager.get_all_client_ids():
             try:
-                from advanced_omi_backend.controllers.websocket_controller import cleanup_client_state
+                from advanced_omi_backend.controllers.websocket_controller import (
+                    cleanup_client_state,
+                )
                 await cleanup_client_state(client_id)
             except Exception as e:
                 application_logger.error(f"Error cleaning up client {client_id}: {e}")
 
+        # Shutdown BackgroundTaskManager
+        try:
+            task_mgr = get_task_manager()
+            await task_mgr.shutdown()
+            application_logger.info("BackgroundTaskManager shut down")
+        except RuntimeError:
+            pass  # Never initialized
+        except Exception as e:
+            application_logger.error(f"Error shutting down task manager: {e}")
+
         # RQ workers shut down automatically when process ends
         # No special cleanup needed for Redis connections
 
@@ -250,7 +297,9 @@ async def lifespan(app: FastAPI):
 
         # Shutdown plugins
         try:
-            from advanced_omi_backend.services.plugin_service import cleanup_plugin_router
+            from advanced_omi_backend.services.plugin_service import (
+                cleanup_plugin_router,
+            )
             await cleanup_plugin_router()
             application_logger.info("Plugins shut down")
         except Exception as e:

backends/advanced/src/advanced_omi_backend/chat_service.py

@@ -26,8 +26,8 @@
 from advanced_omi_backend.services.memory import get_memory_service
 from advanced_omi_backend.services.memory.base import MemoryEntry
 from advanced_omi_backend.services.obsidian_service import (
-    get_obsidian_service,
     ObsidianSearchError,
+    get_obsidian_service,
 )
 from advanced_omi_backend.users import User
 

backends/advanced/src/advanced_omi_backend/client.py

@@ -12,7 +12,6 @@
 from pathlib import Path
 from typing import Dict, List, Optional, Tuple
 
-from advanced_omi_backend.task_manager import get_task_manager
 from wyoming.audio import AudioChunk
 
 # Get loggers

backends/advanced/src/advanced_omi_backend/client_manager.py

@@ -9,6 +9,7 @@
 import logging
 import uuid
 from typing import TYPE_CHECKING, Dict, Optional
+
 import redis.asyncio as redis
 
 if TYPE_CHECKING:
@@ -39,17 +40,6 @@ def __init__(self):
         self._initialized = True  # Self-initializing, no external dict needed
         logger.info("ClientManager initialized as single source of truth")
 
-    def initialize(self, active_clients_dict: Optional[Dict[str, "ClientState"]] = None):
-        """
-        Legacy initialization method for backward compatibility.
-
-        New design: ClientManager is self-initializing and doesn't need external dict.
-        This method is kept for compatibility but does nothing.
-        """
-        if active_clients_dict is not None:
-            logger.warning("ClientManager no longer uses external dictionaries - ignoring active_clients_dict")
-        logger.info("ClientManager initialization (legacy compatibility mode)")
-
     def is_initialized(self) -> bool:
         """Check if the client manager has been initialized."""
         return self._initialized
@@ -314,40 +304,6 @@ def get_client_manager() -> ClientManager:
     return _client_manager
 
 
-def init_client_manager(active_clients_dict: Dict[str, "ClientState"]):
-    """
-    Initialize the global client manager with active_clients reference.
-
-    This should be called from main.py during startup.
-
-    Args:
-        active_clients_dict: Reference to the global active_clients dictionary
-    """
-    client_manager = get_client_manager()
-    client_manager.initialize(active_clients_dict)
-    return client_manager
-
-
-# Client-user relationship initialization and utility functions
-def init_client_user_mapping(
-    active_mapping_dict: Dict[str, str], all_mapping_dict: Optional[Dict[str, str]] = None
-):
-    """
-    Initialize the client-user mapping with references to the global mappings.
-
-    This should be called from main.py during startup.
-
-    Args:
-        active_mapping_dict: Reference to the active client_to_user_mapping dictionary
-        all_mapping_dict: Reference to the all_client_user_mappings dictionary (optional)
-    """
-    global _client_to_user_mapping, _all_client_user_mappings
-    _client_to_user_mapping = active_mapping_dict
-    if all_mapping_dict is not None:
-        _all_client_user_mappings = all_mapping_dict
-    logger.info("Client-user mapping initialized")
-
-
 def register_client_user_mapping(client_id: str, user_id: str):
     """
     Register a client-user mapping for active clients.

backends/advanced/src/advanced_omi_backend/clients/audio_stream_client.py

@@ -48,7 +48,11 @@ async def main():
 import websockets
 from websockets.client import WebSocketClientProtocol
 
-from advanced_omi_backend.constants import OMI_CHANNELS, OMI_SAMPLE_RATE, OMI_SAMPLE_WIDTH
+from advanced_omi_backend.constants import (
+    OMI_CHANNELS,
+    OMI_SAMPLE_RATE,
+    OMI_SAMPLE_WIDTH,
+)
 
 logger = logging.getLogger(__name__)
 

backends/advanced/src/advanced_omi_backend/clients/gdrive_audio_client.py

@@ -1,6 +1,8 @@
-import os 
+import os
+
 from google.oauth2.service_account import Credentials
 from googleapiclient.discovery import build
+
 from advanced_omi_backend.app_config import get_app_config
 
 _drive_client_cache = None

backends/advanced/src/advanced_omi_backend/controllers/__init__.py

@@ -3,11 +3,11 @@
 """
 
 from . import (
-    memory_controller,
-    user_controller,
-    conversation_controller,
     client_controller,
+    conversation_controller,
+    memory_controller,
     system_controller,
+    user_controller,
 )
 
 __all__ = [